-
-
No need for the \, since the parens guarantee Python won't get confused. "by default," (with the comma) and not "by-default"
-
Seems like the set() math should be part of load_config_files instead. Once you've done that, you no longer need to convert this all into a dictionary. You'll just have one that you can iterate.
-
-
-
No need for re.split. You can just do str.split(delimiter). Also, we should avoid map and filter where possible. They're less readable and Python suggests not using them. Instead, this can be: [s.strip() for s in line.split(":")] for line in text.splitlines() if line You also don't really need to turn this into a dictionary. This whole thing can be greatly simplified: values = [[s.strip() for s in line.split(":")] for line in text.splitlines() if line] for key, value in values: self.assertEquals(value, ...) Actually... What's this even doing? It's just comparing itself with itself. So something is wrong here.
-
-
-
-
New rb-config command - shows user configuration.
Review Request #2548 — Created Aug. 14, 2011 and submitted
For now we can't provide command for changing '.reviewboardrc', so the new command only lists configuration values in pretty form.
Description | From | Last Updated |
---|---|---|
The "by default," wasn't addressed. |
chipx86 | |
No need for the \, since the parens guarantee Python won't get confused. "by default," (with the comma) and not … |
chipx86 | |
Seems like the set() math should be part of load_config_files instead. Once you've done that, you no longer need to … |
chipx86 | |
Can you import rbconfig instead, and then call rbconfig.main()? |
chipx86 | |
ouput? |
chipx86 | |
No need for re.split. You can just do str.split(delimiter). Also, we should avoid map and filter where possible. They're less … |
chipx86 | |
Should be clear that it's testing in rb config. |
chipx86 | |
Should be clear that it's testing in rb config. |
chipx86 | |
"Test the '-a/--all' option in rb-config" |
chipx86 | |
This needs to be: try: from cStringIO import StringIO except ImportError: from StringIO import StringIO |
chipx86 | |
I think you can use StringIO instead of this. |
chipx86 | |
ouput? |
chipx86 | |
I meant use StringIO here. We don't need OutputBuffer. |
chipx86 | |
Whatever is done here needs to be heavily commented. Can you instead just do: builtin = globals()? |
chipx86 |