- Change Summary:
-
An Older file that was no longer required was taken out.
- Diff:
-
Revision 2 (+2187)
rb_installer scripts in progress
Review Request #2460 — Created July 10, 2011 and discarded
The Linux Installer are the older version, The newer version will be posted. Windows installer are only for the 64bit version OS, but they work with 32bits as well.
Testing was done on 64bit machines.
Description | From | Last Updated |
---|---|---|
alphabetical order, and then two linebreaks between the imports and the from import. Two linebreaks between the from imports and … |
mike_conley | |
How come only some of these have #! lines at the top? |
mike_conley | |
See other comment, re: long strings. |
mike_conley | |
space after commas |
mike_conley | |
Space after commas |
mike_conley | |
Same, re: this directory existing... |
mike_conley | |
Are we sure that "C:\Program Files (x86)" will exist? |
mike_conley | |
Can we assume that this directory exists? |
mike_conley | |
spaces before * |
mike_conley | |
ws |
mike_conley | |
Spaces on either side of the + |
mike_conley | |
spaces on either side of the = |
mike_conley | |
Spaces on either side of the = |
mike_conley | |
Space before the *. |
mike_conley | |
Spaces on either side of the =, +'s |
mike_conley | |
Spaces between functions. Applies to all below. |
mike_conley | |
Spaces after commas, on either side of = |
mike_conley | |
Typo - "installation" - also, why do some of these give off the "installation complete" message, and others do not? |
mike_conley | |
Spaces (see above) |
mike_conley | |
Spaces for = |
mike_conley | |
ws |
mike_conley | |
Still need this? |
mike_conley | |
Hm - maybe we'll just use standard escaped quotes instead of those weird characters. |
mike_conley | |
I see - we build the folder for them...gotcha. Do we clean up afterwards? |
mike_conley | |
ws |
mike_conley | |
We should probably be consistent with our capitalization. |
mike_conley | |
Please put these in alphabetical order |
mike_conley | |
Two linebreaks between this from import and the other imports. |
mike_conley | |
For these, spaces after the commas. And the PossibleApplications line needs to be broken up over several lines. |
mike_conley | |
Spaces on either side of the = sign |
mike_conley | |
Spaces on either side of the = |
mike_conley | |
Instead of running commands right from the root of the script, I think I'd prefer to have a main function … |
mike_conley | |
? |
mike_conley | |
ws |
mike_conley | |
Temp file |
mike_conley | |
temp file |
mike_conley | |
temp file |
mike_conley | |
temp file |
mike_conley | |
Spaces after commas |
mike_conley | |
Spaces on either side of = |
mike_conley | |
ws |
mike_conley | |
ws |
mike_conley | |
Needs formatting cleanup, spaces on either side of =... This entire series of instructions, starting from line 26, should probably … |
mike_conley | |
I'm seeing lots of "prints" everywhere...shouldn't we be piping to stdout and stderr? |
mike_conley | |
ws |
mike_conley | |
I think this tilde file is likely temporary, and shouldn't have been included in the review request. |
mike_conley |
-
-
alphabetical order, and then two linebreaks between the imports and the from import. Two linebreaks between the from imports and the first function, and two linebreaks between functions. These comments apply to all files below.
-
-
You might benefit instead with different syntax for long strings - see http://docs.python.org/tutorial/introduction.html#strings
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Typo - "installation" - also, why do some of these give off the "installation complete" message, and others do not?
-
-
-
-
-
-
-
-
-
-
-
-
For these, spaces after the commas. And the PossibleApplications line needs to be broken up over several lines.
-
-
-
Instead of running commands right from the root of the script, I think I'd prefer to have a main function that runs each command, and then to call that main function.
-
-
-
-
-
-
-
-
-
-
-
Needs formatting cleanup, spaces on either side of =... This entire series of instructions, starting from line 26, should probably be in a "main" function, which gets called at the end of the file with sys.argv.
-
-
-
I think this tilde file is likely temporary, and shouldn't have been included in the review request.