-
-
Do you really need a regex for this? I'd think you could do: if pattern in request.path: However, I'm not sure we want to represent the current page with this. First of all, we should never presume to know the path to a URL, and therefore shouldn't pass it in as a parameter. So instead, this template tag should take a name, which will be the URL name passed to {% url %}. This function should then compare that path with request.path (and it should be able to do a direct ==). -
-
-
-
-
-
Style and Template update to the Admin area
Review Request #2451 — Created July 5, 2011 and discarded
Updating admin.css and some base templates to make it look more like the core application. 1. Added "Back to Review Board" button (see screenshot) 2. Added "Administration" into main branding title when the user is browsing the admin section (see screenshot) 3. Updated sub navigation styles (see screenshot) 4. Minor updated to SSH Settings, wrapped the SSH configs into a bordered box, so it looks like other settings page. 5. Other minor style fixes. Binary and branch available at https://github.com/vladikoff/reviewboard/tree/header-styles
Testing in Browsers: Chrome (Win with v.13 beta/Ubuntu with v.11), Firefox 3.6 (Win/Ubuntu), IE7/8, Opera (Win)
Screenshots
| Description | From | Last Updated |
|---|---|---|
|
Do you really need a regex for this? I'd think you could do: if pattern in request.path: However, I'm not … |
 chipx86
|
|
|
Blank line between these. |
chipx86
|
|
|
Only one space before %} |
chipx86
|
|
|
Indentation should be 1 space. Same with other lines in the file. |
chipx86
|
|
|
Inconsistencies in the indentation. |
chipx86
|
|
|
More indentation problems. |
chipx86
|
|
|
I don't think we localize in this template, so this could be removed. |
chipx86
|
VL
- Change Summary:
-
Updated with fixes.
- Diff:
-
Revision 2 (+263 -128)
VL
- Change Summary:
-
Added the github branch link
- Description:
-
Updating admin.css and some base templates to make it look more like the core application.
- Added "Back to Review Board" button (see screenshot)
- Added "Administration" into main branding title when the user is browsing the admin section (see screenshot)
- Updated sub navigation styles (see screenshot)
- Minor updated to SSH Settings, wrapped the SSH configs into a bordered box, so it looks like other settings page.
- Other minor style fixes.
+ + Binary and branch available at https://github.com/vladikoff/reviewboard/tree/header-styles
-
On pages with breadcrumbs (such as looking at lists of particular items), the breadcrumbs just kind of hover below the navigation bar. It would be nice to find a home for them.
-
This looks nice, but I think it would be nice if it was more visually apparent that this is an admin area. I think this is especially necessary because the main pages have "My Dashboard", which is different from the "Dashboard" here, but they look like they're the same.
-
I'm not sure about the "tab" look here of the subnav. It worked when the header was 100% width but because there's no border around the page contents, it just seems like it's floating in mid-air here. I'm also not sure about the mix of boxes-with-borders, boxes-without-borders, and hovering items.
VL
- Change Summary:
-
Trying out a different approach to the sub-nav and other stuff, based on feedback.
- Diff:
-
Revision 3 (+287 -137)