• 
      

    Add support for working file attachment comments.

    Review Request #2380 — Created May 25, 2011 and submitted

    Information

    Review Board

    Reviewers

    Add support for working file attachment comments.
    
    Commenting on a file attachment now works much like diffs and screenshots,
    with a comment dialog and a list of existing comments.
    
    File attachments only have comments made on them as a whole.
    
    We may want to change the UI a bit later, perhaps indicate draft comments
    visually like we do with other comment flags. For now, though, this gives
    us something we can test with.
    Commented on a few different files. I was able to add and change the comment,
    see existing comments made, and see them in the review.
    david
    1. 
        
    2. Don't add this line.
    3. reviewboard/htdocs/media/rb/js/reviews.js (Diff revision 1)
       
       
       
      .one?
      1. It binds to the signal, but only once, and then unbinds.
    4. 
        
    david
    1. Are you going to push this?
      1. Looks like I did and just forgot to close it.
    2.