It would be awesome if we showed the message below this. Sort of like the review request draft banner, but not editable. Or actually... Rather than the edit box introduced in this change, this might be a better workflow:
1) Click Close -> Submitted
2) Page changes to this (no big edit box first).
3) The submit banner has an editable field for the description (much like review request draft banners).
The field would be different than the standard fields. It'd be more of an instant apply. No draft. Change it and everyone sees it. For the ChangeDescription model, we could just do:
changedesc = latest change description;
if changedesc has field 'status':
set changedesc.close_description;
else:
create new changedesc with close message.
That means if you were to set a new close description, and there's already a change description for it, any modifications to that close description would just overwrite what's already in there. That would happen until some other change descrption has been created (new diff, field changes), in which case we just make a new one.
I actually think this is the way to go. No extra work for those who just want to simply close a review request, and yet it's very straight-forward to update the description once submitted (even for old review requests).
chipx86:
Which Description is this? The submit message? I think we need to rename it if so, or somehow change how we show this.
For now, maybe just "Close Description" ?
It would be awesome if we showed the message below this. Sort of like the review request draft banner, but not editable. Or actually... Rather than the edit box introduced in this change, this might be a better workflow: 1) Click Close -> Submitted 2) Page changes to this (no big edit box first). 3) The submit banner has an editable field for the description (much like review request draft banners). The field would be different than the standard fields. It'd be more of an instant apply. No draft. Change it and everyone sees it. For the ChangeDescription model, we could just do: changedesc = latest change description; if changedesc has field 'status': set changedesc.close_description; else: create new changedesc with close message. That means if you were to set a new close description, and there's already a change description for it, any modifications to that close description would just overwrite what's already in there. That would happen until some other change descrption has been created (new diff, field changes), in which case we just make a new one. I actually think this is the way to go. No extra work for those who just want to simply close a review request, and yet it's very straight-forward to update the description once submitted (even for old review requests).