Prepare SCMTools for LocalSite-based SSH keys.
Review Request #2328 — Created May 1, 2011 and submitted — Latest diff uploaded
Prepare SCMTools for LocalSite-based SSH keys. Some of the SCMTool classmethods gained local_site_name parameters, which will later be used for finding the appropriate SSH keys and such. The forms and webapi code provide the necessary local_site_name to the functions, ensuring that the SCMTools will have the correct information when verifying repositories. SCMTool gained a popen() function that wraps subprocess.Popen, setting a few common parameters and passing in a new RB_LOCAL_SITE environment variable that rbssh will be able to use to access the correct LocalSite info.
Unit tests pass. Tested this along with the other pending changes.
reviewboard/scmtools/bzr.py |
---|
reviewboard/scmtools/core.py |
---|
reviewboard/scmtools/cvs.py |
---|
reviewboard/scmtools/forms.py |
---|
reviewboard/scmtools/git.py |
---|
reviewboard/scmtools/plastic.py |
---|
reviewboard/scmtools/svn.py |
---|
reviewboard/webapi/resources.py |
---|
reviewboard/webapi/tests.py |
---|