Bare repositories and git-rev-parse support in post-review.

 






 

 


  Review Request #2233
  —
  Created April 3, 2011 and submitted

 


















 

  

   Information

  





 
 

  jan.koprowski
 









 
 

  RBTools
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
Review can be done also inside bare repository. Also --revision-range="" can be any git-revision from git-rev-parse manual: http://www.kernel.org/pub/software/scm/git/docs/git-rev-parse.html.

 








  


 
 

  
Tested under Linux on Git 1.7.4.1
On normal clone - made by "git clone"
On bare repository - made by "git init --bare"
On bare clone - made by "git clone --bare"

 







 









 





  








 









 






  

 








 














 





 

  

   




jan.koprowski




   

   





  

 



 

  


   

   

    
 
jan.koprowski



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Don't rush with this patch please :)
I'm trying to make this part even more general and I will try to made them even more flexible then this.
I will get You know when it be done.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




jan.koprowski




   

   

  

 



 















 



 

  

   




jan.koprowski




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  















  

   

    Testing Done:
   

   

    
 ~   
Tested under Linux on Git 1.7.4.1
   ~ 
Tested under Linux on Git 1.7.4.1
   + On normal clone - made by "git clone"
   + On bare repository - made by "git init --bare"
   + On bare clone - made by "git clone --bare"

   

  












  

 
















 





 

  

   




jan.koprowski




   

   





  

 



 

  


   

   

    
 
jan.koprowski



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Is there chance to put it in rbtools released with ReviewBoard 1.6?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Definitely. You originally said not to rush so I assumed it wasn't done :) But then I missed the update after that.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




jan.koprowski




   

   







  

 



 

  


   

   

    
 
jan.koprowski



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Thanks! Committed to master (d7ec4f4)
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3.