- Change Summary:
-
Added screenshot.
- Testing Done:
-
+ Manual testing using the extension I made.
Review Request Drop Down U.I. Extension
Review Request #2224 — Created March 30, 2011 and submitted
I needed a drop down menu for an extension I was building so I built an extension to do just that. Very similar to the standard button extension, except it's a list of buttons essentially.
Manual testing using the extension I made.
-
-
The comment should be more like the one above. It should be clear from reading it exactly what it's purpose is. First line, on the """, in the form of a quick summary without "This is" or similar.
-
-
I'm also confused about this. Also the "see above." What should be in here? Is it actually ActionHook instances?
-
-
-
The image path is being hard-coded and doesn't contain a media serial. Please use: {{MEDIA_URL}}rb/images/dropdown.png?{{MEDIA_SERIAL}}
-
-
Committed with a few style fixes. Thanks! There are a few small question marks in my head about the bet way to implement this dropdown actionhook. I almost want a standard ActionHook to be able to supply sub-items. Also, I sort of think it should be more generic so it can be used in the diff viewer too. However, it's fine for now, and I think it's very likely we'll be revisiting how actionhooks work by the time we ship extensions in a release.