- Change Summary:
-
Sorry, there some commits mixed up on the previous review request.
- Description:
-
Add 'show unread review request' filter into 'to-me' view
Add an filter into 'to-me' view to provide an option to list unread review requests only.
- - Fix appending the "Press Tab to auto-complete" footer on autocomplete dropdowns.
- - Only the first autocomplete dropdown used would receive the "Press Tab to
- auto-complete" footer. We would look for the ".ui-autocomplete-results" and - only append if we didn't see a footer in it. However, once a second autocomplete - dropdown was shown, due to our query, we'd show that there was at least one - footer, and skip adding a new one. - - Now we use a query to find specifically those results divs without a footer,
- and add to all the ones found. - - Allow blank local IDs for review requests in the admin UI.
- - Attempting to save a review request entry in the admin UI that contained
- a blank local ID would fail. We now tell this field that blank values - are allowed. - - Fixes bug #2003.
- - Rb breaks Git patches with new files/deleted files
- - No longer removes lines from git diffs that are required for patching.
- - Testing done: Fixed the tests that checked the length of the file. Made some
- diffs and applied them. - Reviewed at http://reviews.reviewboard.org/r/2164/ - Fixes bug 1715. - - Release Review Board 1.6 Beta 1.
- - - - Added release notes for Review Board 1.6 Beta 1.
- - - - Merge branch 'release-1.5.x'
- - - - Provide MEDIA_URL and MEDIA_SERIAL in HTML e-mails.
- - The MEDIA_URL and MEDIA_SERIAL were missing in HTML e-mails. The lack of
- MEDIA_URL meant that graphical parts of the e-mail wouldn't display and, - more problematic, "rb" would be appended to the domain (since the slash - separator came from MEDIA_URL), causing some e-mail clients to warn about - accessing contents from unknown domains. - - Provide a "Show SSH Public Key" option in the Add/Change Repository page.
- - Finding the SSH public key can be difficult on a standard Review Board
- setup, and if the user has access only to the repository parts of the - admin UI, they can't get the public key. - - This provides a "Show SSH Public Key" button in the top-right of the
- Add/Change Repository page, which will toggle the display of a box containing - the public key. - - Use the right username as the default if no username is provided.
- - We were using os.getlogin() to determine the proper username, but this is just
- the username of the user who logged into the current shell, not necessarily - the current user. We now use getpass.getuser() to get the true username. - - Merge branch 'release-1.5.x'
- - - - Release Revie WBoard 1.5.4.
- - - - Add release notes for 1.5.4.
- - - - Fix the documentation on Error 218 - Repo Authentication Error.
- - The documentation listed the HTTP status code as 400, but it should have
- been 403. - - Merge branch 'release-1.5.x'
- - - - Fix a build breakage with the RSAKey generation in webapi tests.
- - Paramiko seems to require RSA key lengths of a minimum of 1024. This didn't
- come up during unit tests on my system, but nightly builds were affected by it. - - Merge branch 'release-1.5.x'
- - - - Remove a call to repository.is_accessible_by.
- - When backporting the new repository creation/modification API, I left in a
- call to repository.is_accessible_by, which isn't available on 1.5.x. We don't - have repository access permissions in this release, so remove the call. - - Merge branch 'release-1.5.x'
- - - - Provide compatibility with IntelliJ-generated SVN diffs.
- - IntelliJ diffs represent the working directory with "(revision )" instead
- of "(working copy)". This is a bit broken, but it's easy to support it. - We now check for either of this and map it to HEAD. - - Fixes bug #1937
- - Prevent a semi-rare breakage with comments ending in collapsed regions.
- - Comments that started in a non-collapsed region but ended in a collapsed
- region would cause us to access an invalid entry in the table.rows array - past the end of the array. We now check before accessing this. - - Fixes bug #1564
- - Fix problems with publishing reviews.
- - A recent change of mine to stop using ?api_format=json on screenshot posts
- ended up breaking review publishing. We were only setting this if there was - a dictionary of data, but we also want to set if there's no data being sent. - - Show ' correctly in names when replying to reviews.
- - We were doubly escaping full names for display: Once when setting
- gUserFullName, and once when actually displaying it (using $.text() instead - of $.html()). Now we set the name as html instead of text so we display the - right thing. - - Fixes bug #1980
- - Fix a breakage when accessing the old update_changenum JSON API function.
- - The old JSON API's update_changenum function wasn't handling the
- api_format argument being passed, leading to an exception when trying to - call the function. We now accept args, *kwargs like the other API handlers. - - Fixes bug #1948
- - Fix a breakage when using bug numbers on review requests without repositories.
- - Our code to generate a bug URL assumed the existence of a repository, which
- is no longer required on review requests (such as ones that consist only of - images to review). We're more careful now not to assume there's a repository - in this case. - - Fixes bug #1982
- - Allow usernames with '@' in the admin backend
- - It is an usual situation for LDAP servers use the mail attribute
- for authentication. If ReviewBoard is set up to authenticate using - an email attribute, login is successful and the user data is - correctly populated. Nevertheless, it is not possible to change the user - field as the username is considered incorrect. - - This commit relaxes the restriction in the admin backend to allow for
- the '@' character in usernames. There is no need to perform a similar - change in the frontend code as LDAP registrations do not follow the same path - as basic registrations. - - Reviewed at http://reviews.reviewboard.org/r/2124/
- - Merge branch 'release-1.5.x'
- - - - Add API for change number-related updates.
- - This adds some missing API for both updating the associated change number
- for a review request, and updating the review request's information based on - the change number. These two things were missing from the new API, and were - provided by the old one. - - To simply update the review request's information based on a change number,
- a PUT changenum=<changenum> with the existing change number should be called. - Specifying a different change number will attempt to update which change the - review request is pointing to, and then update the information from that. - - These are needed for post-review, and will be backported to release-1.5.x.
- - Merge branch 'release-1.5.x'
- - - - Add support in the API for admins to create repositories.
- - This provides HTTP POST/PUT/DELETE support for /api/repositories, allowing
- administrators to create, modify, or "delete" (hide) repositories. - - The API can return a number of errors, based on configuration problems or host
- access problems (such as bad/unknown SSH keys or unknown certificates). In the - cases where it's host-related information that needs to be verified, the API - can respond to the error by repeating the request and sending trust_host=1. - - Unit tests were added to test creating, updating, and deleting repositories,
- and testing the various error results. - - Check for permissions on PUT for review request resources.
- - We were relying on open/close to check proper permissions when executing
- close/reopen, but we'd ideally want to check before going that far. Now - we execute checks in the update handler so we catch things early. - - Reviewed at http://reviews.reviewboard.org/r/2138/
- - Add support in the API for admins to create repositories.
- - This provides HTTP POST/PUT/DELETE support for /api/repositories, allowing
- administrators to create, modify, or "delete" (hide) repositories. - - The API can return a number of errors, based on configuration problems or
- host access problems (such as bad/unknown SSH keys or unknown certificates). - In the cases where it's host-related information that needs to be verified, - the API can respond to the error by repeating the request and sending - trust_host=1. - - Unit tests were added to test creating, updating, and deleting repositories,
- both on global sites and LocalSites, and testing the various error results. - - Reviewed at http://reviews.reviewboard.org/r/2137/
- - Consolidate user logins in webapi tests.
- - Many webapi tests needed to re-login with specific users, which may be
- members of a LocalSite and/or admins. - - This adds a _login_user function that takes parameters indicating whether the
- user should be part of a local_site and/or whether they should be an admin. - It will determine the right user, potentially add it to the LocalSite's admin - lists, and log in. This reduces the amount of code in the tests and will be - used for the upcoming repository tests, which make extensive use of this. - - Reviewed at http://reviews.reviewboard.org/r/2134/
- - Check for permissions on PUT for review request resources.
- - We were relying on open/close to check proper permissions when executing
- close/reopen, but we'd ideally want to check before going that far. Now - we execute checks in the update handler so we catch things early. - - Reviewed at http://reviews.reviewboard.org/r/2138/
- - Fix individual unit test selection.
- - A recent change hard-coded testing of all of Review Board's codebase. This
- moves back to using --where so that, by default, it will test the whole - codebase, but if a specific module is used, it will test that instead. - - Reviewed at http://reviews.reviewboard.org/r/2136/
- - Make some improvements to the user info popup.
- - This improves a few aspects of the new popup:
- - 1) Instead of using an image to define the shape and dimensions of the
- popup, we now use CSS3's drop shadows and rounded corners, and we - set the width/height in ems. This makes things look nicer when zoomed - in, and should let us easily change the shape. - - 2) Changed the contents to be less key/value-ish. It now shows
- the username, full name, and e-mail with no labels, and then some - human-readable "Last logged in blah blah" and "Joined blah blah." - - 3) Instead of loading the popup every time we mouse over, we now load it
- once and keep it around. This could use some improving still. I'd like - to have a $.fn.userInfoBubble() or something that manages all this, - and to keep one bubble with the info cached, as that'll be more - efficient if we add popups for submitters on the review request pages, - but that can come later. - - 4) Use etags for the info bubble, so we can avoid rendering and transferring
- content if nothing's changed. - - 5) Make use of the hcard semantics for the content in user_infobox.html.
- - Fix screenshot drag-and-drop.
- - Screenshot drag-and-drop broke in 1.6 due to a change to force the
- mimetype for responses. I added code to add "api_format=json" to the - data dictionary, which did interesting things when data was not a dictionary - but instead was a string. It therefore lost string's functions, which broke - jQuery's ajax functions. - - Now screenshot drag-and-drop works once again.
- - Add a user page and hover preview.
- - Currently when a user visits /users/<user name>, all of the review requests of
- that user are shown. This patch modifies this page slightly to include more - information. This is a first step, and I've tried to make it as simple as - possible. Further modification will probably be needed. - - I have also added a hover preview. When the cursor moves over top of a user
- name a small preview of that user will be shown (see screenshot). This feature - is only supported on the review request pages (not in the "submitters" page for - example). This could be added later, but was omitted due to the possibility of - too many images appearing. - - Reviewed at http://reviews.reviewboard.org/r/1953/
- - Provide a "Show SSH Public Key" option in the Add/Change Repository page.
- - Finding the SSH public key can be difficult on a standard Review Board
- setup, and if the user has access only to the repository parts of the - admin UI, they can't get the public key. - - This provides a "Show SSH Public Key" button in the top-right of the
- Add/Change Repository page, which will toggle the display of a box containing - the public key. - - Merge branch 'release-1.5.x'
- - - - Release Review Board 1.5.3.1, a hot-fix release for search index validation.
- - - - Fix search index validation on the General Settings page.
- - The new search index validation broke for any user that didn't have a
- valid, writable, existing search index file specified. This was a problem - for new and existing users. - - Now we only validate access if the file exists, and we don't validate
- existence, since it's perfectly fine for it not to exist yet. We also fall - back early if nothing was specified. - - Even once providing valid information, we weren't saving it, so users
- could never get passed this stage. We now make sure to return the value - so it saves in the database. - - Add release notes on RBTools v0.3.2.
- - - - Release 1.5.3.
- - - - Merge branch 'release-1.5.x'
- - - - Added release notes for Review Board 1.5.3.
- - - - Update the documentation on post-review configuration.
- - Added new documentation on the REVIEWBOARD_URL and REPOSITORY settings in
- .reviewboardrc. I split the settings into their own little sub-sections. - - I also removed the section on internal post-review configuration. It soon
- won't be possible to do without complete custom builds, and that should be - a whole different topic. - - Add release notes for RBTools 0.3.1.
- - - - Add the ability to run through different top-level test modules.
- - - - Upgrade our version of ez_setup.py.
- - Our version of ez_setup.py was too old, pointing to an unavailable
- version of setuptools. - - Merge branch 'release-1.5.x'
- - - - Allow unknown host keys for SSH connections while running unit tests.
- - Requiring known host keys during unit tests is problematic and means
- extra setup. Since we don't really care about the security here, just - warn on invalid host keys while running tests. - - Add unit tests for SSH-backed repositories.
- - This adds some unit tests for testing connections to SSH-backed repositories
- using rbssh. These tests are a bit special, and require access to some - arbitrary repositories which must be configured in settings.py. A template - for these have been provided in settings_local.py.tmpl. If these aren't - defined, the tests will just skip. - - Using logging instead of our own debug handler and printing.
- - The advantage of using logging is that we have less code to deal with,
- and we can gater information not just from rbssh but also from paramiko - in the log files. - - Fix communication problems with rbssh on Windows.
- - This fixes problems with rbssh on Windows. The process was hanging around
- forever instead of properly shutting down. We now let stdin processing - drive in the main thread and then, upon closing, we trigger a shutdown - of the writer, which should close the other end and shut down the process. - - Implement several fixes to rbssh.
- - rbssh had problems with some types of repositories. Mostly, they expected
- certain command line options to be available that weren't. We now support - -q/--quiet, -s (for subsystem selection), and -V (print version). - - In general, the rbssh code has been cleaned up to be a bit better structured
- and less hacky. We have classes for Posix and Windows, rather than - individual functions. We also now tell OptionParser to leave behind any - unknown arguments so that we can pass them to the command to run on the - other server. - - rbssh now supports a shell and sftp. If a valid key or password wasn't
- available during authentication, we prompt for a new password. We do this - three times before giving up. - - Fix Bazaar SSH/SFTP support.
- - Bazaar's BZR_SSH environment variable doesn't just accept any arbitrary
- path. It requires some known, registered value. An "SSH Vendor," as they - call it. We now register rbssh as such a vendor, and serialize the parameters - sent to it. - - This supports sftp and ssh-backed repositories.
- - Support taking a repository name when creating a review request.
- - Historically, we've supported taking a numeric repository ID or a
- repository path as an argument, which works fine when dealing with - setups with only one or two possible paths. However, for Git and other - such types of repositories, you may have a dozen different paths, since - they may be SSH-backed with a username. This causes creation to fail, - even though each of these may really be the same repository. - - This supports taking a repository name in place of an ID or path when
- creating a new review request. The name would be the exact same name you'd - see in the New Review Request page. - - This requires tools to know that they can pass a name. RBTools will soon be
- updated for this.
Add 'show unread review request' filter into 'to-me' view
Review Request #2190 — Created March 8, 2011 and discarded
Add 'show unread review request' filter into 'to-me' view Add an filter into 'to-me' view to provide an option to list unread review requests only.
Manually tested in devserver. Worked fine.
HO