-
-
This is too much work for what is already built into urllib2. We want to do: opener = urllib2.build_opener(urllib2.ProxyHandler(), urllib2.UnknownHandler(), urllib2.HTTPHandler(), ...) -
-
-
This would have to be AttrDict, to keep with the syntax, but I'm not really a fan of this. I'd rather we either have a class with these methods or just use a dict.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
This should be wrapped to 80 characters and should be a bit more human-readable. The error isn't really correct. You can diff by filenames. We just don't support it. The error should be more clear and say that we don't support diffs by filenames. Blank line after this line.
-
-
-
-
I'd prefer this to go back to how it was. Also, You removed the blank line between the text and URL.
-
-
-
-
-
This change is going to be a problem. We need to keep the existing method of assuming changenum on Perforce. Otherwise we're going to break a lot of setups. Also, the revision range stuff cannot change. For the same reasons.
-
-
-
-
-
-
-
-
improve scriptability of post-commit
Review Request #212 — Created Jan. 25, 2008 and discarded
* post_review separated from __main__ to allow importing from other scripts such as post-commit hook; allows any command-line option to be set programatically in call to post_review method * adds --submit-as option * adds --repository option; allows empty basedir for repo diffs * includes json responses in debug mode * consolidates .reviewboardrc loading into one place in __main__ * allow use of -c (--revision) with svn and removed -c as a weird special case in parse_options; removed --revision-range: reviewing multiple revisions in svn makes as little sense as in p4 * generalizes and expands request field setting in mutable_request_fields * allows any (long-form) command-line option to be set in .reviewboardrc (backwards incompatibility: this means "REVIEWBOARD_URL" in .reviewboardrc should now be just "server"); if also specified on command-line, command-line takes precedence I've included this as a diff against post-review but the name needs to be changed to make it importable (hyphens are not legal in a module name). I used the obvious "post_review.py"
