Welcome to the Splat alpha!

This looks to me like there are a couple problems.

First, your Apache configuration likely was never updated to set the HOME variable. It should be set to {yoursitedir}\data (make sure this directory exists and is writeable by the web server). The generated key should go there.

Second, there may be some issue on Windows launching rbssh. Or it may be local to your system. I assume you can run rb-site from your user for the upgrade. Can you manually run rbssh?

If you can, it's possible that your system-wide path isn't taking into account the directory where rbssh lives. You'll need to update that and reboot.

• Status:

  +	NeedInfo

Thanks for writing back quickly!
I see now that another user had overridden the system path to point at a different python scripts directory, doh.
Now rbssh can load, but now rbssh-script.py fails with an import error on the module pwd.

ImportError: No module named pwd

Where can I get this module?  Perhaps it should be added in the upgrade process

2011-01-26 17:28:23,963 - ERROR - Git: Failed to find valid repository ssh://xxx.xxx.com/somerepo.git: D:\Python25\lib\site-packages\Crypto\Util\randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases.  See http://www.pycrypto.org/randpool-broken

  RandomPool_DeprecationWarning)

Traceback (most recent call last):

  File "D:\Python25\Scripts\rbssh-script.py", line 8, in <module>

    load_entry_point('ReviewBoard==1.5.2', 'console_scripts', 'rbssh')()

  File "d:\python25\lib\site-packages\ReviewBoard-1.5.2-py2.5.egg\reviewboard\cmdline\rbssh.py", line 205, in main

    client.connect(hostname, username=username)

  File "build\bdist.win32\egg\paramiko\client.py", line 319, in connect

  File "D:\Python25\lib\getpass.py", line 106, in getuser

    import pwd

ImportError: No module named pwd

P.S. I have pycrypto 2.1 installed for python 2.5

pwd is a Linux-only Python module, as far as I can tell. It looks like Python assumes it can access it, even though it can't. This is outside our control.

Something you can try for getting around this is to make the username part of the SSH URL. It will then parse it out and include it, bypassing the call to getuser.

Ah, good idea.  I made my username part of the SSH URL now and it is able to skip over the pwd call.
It now complains that the authentication failed.  It appears that it is trying to connect with just a hostname and username, no password, even though a password was specified in the repository configuration form.  It was able to log in successfully in keyboard-interactive mode with the given credentials. 

Does this mean that there's a conflict of authentication method since I tried to generate a SSH key AND I provided login credentials?  If so, is it possible for me to force credentials or undo the SSH key?

It *should* try both password and public key.

Did you try re-generating/uploading a key since making the %HOME% change? If so, it no longer knows about that key.

I tried uploading a key but RB is trying to load the key from the home directory still.  

Ahh.. generate_user_key in sshutils.py just returns the found key in the home directory even if a key is uploaded.

OK so now I have public key authentication working OK.  In the reviewboard logs it discovers the correct key and indicates that authentication with the public key is successful.
Immediately after it successfully logs in with the pubkey, it raises a debug message EOF in transport thread and the reviewboard website fails to respond to the save repository call.

So far I think that it'd be useful to indicate in the SSH settings that if you try to generate a key that it won't override the existing key.  I'm not sure how I ended up at the choice to generate a key because I believe that it's supposed to show you the current key instead and not give you a choice to generate/upload a key.

I'm trying to debug the timeout problem now

After I hit save to save the ssh git repository, the SSH session just seems to die for some reason and then RB times out.  Here's the RB log.

2011-01-31 15:35:03,733 - DEBUG - GitTool: Attempting ssh connection with host: xxx.xxxx.com, username: joeuser
2011-01-31 15:35:03,733 - DEBUG - starting thread (client mode): 0x5caf250L
2011-01-31 15:35:03,795 - INFO - Connected (version 2.0, client OpenSSH_5.2)
2011-01-31 15:35:03,826 - DEBUG - kex algos:['diffie-hellman-group-exchange-sha256', 'diffie-hellman-group-exchange-sha1', 'diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijndael-cbc@lysator.liu.se'] server encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijndael-cbc@lysator.liu.se'] client mac:['hmac-md5', 'hmac-sha1', 'umac-64@openssh.com', 'hmac-ripemd160', 'hmac-ripemd160@openssh.com', 'hmac-sha1-96', 'hmac-md5-96'] server mac:['hmac-md5', 'hmac-sha1', 'umac-64@openssh.com', 'hmac-ripemd160', 'hmac-ripemd160@openssh.com', 'hmac-sha1-96', 'hmac-md5-96'] client compress:['none', 'zlib@openssh.com'] server compress:['none', 'zlib@openssh.com'] client lang:[''] server lang:[''] kex follows?False
2011-01-31 15:35:03,826 - DEBUG - Ciphers agreed: local=aes128-ctr, remote=aes128-ctr
2011-01-31 15:35:03,826 - DEBUG - using kex diffie-hellman-group1-sha1; server key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local hmac-sha1, remote hmac-sha1; compression: local none, remote none
2011-01-31 15:35:03,999 - DEBUG - Switch to new keys ...
2011-01-31 15:35:03,999 - DEBUG - Trying discovered key 2f58fb0653805cffea0cdec82455c096 in D:\ReviewBoard\data/.ssh/id_rsa
2011-01-31 15:35:04,029 - DEBUG - userauth is OK
2011-01-31 15:35:04,686 - INFO - Authentication (publickey) successful!
2011-01-31 15:35:04,795 - DEBUG - EOF in transport thread

For the key, it specifically looks for id_dsa or id_rsa. It sounds like maybe it was still either looking in the wrong location, or you manually copied a file there?

Anyway, the SSH session isn't supposed to be up for too long, as it just runs a small command to get some info, but it seems this is failing. It's probably something specific to the Windows implementation of rbssh, as getting this right on Windows is far, far more tricky than on Linux/Mac, unfortunately.

I have no immediate answer. Until I get a chance to debug this on a Windows system and see if I can reproduce it, the only thing I can suggest is to modify rbssh to do some debugging (you can set DEBUG to True in there and add additional logging with debug("sometihng")), or, ideally, move your server to Linux. Review Board works far better in many ways on Linux than it does on Windows, due to the many dependencies we use being primarily tested on Linux.

I couldn't get too much info the pipe just terminates prematurely without a good reason.

I set up a new reviewboard instance on an ubuntu vm and everything works swimmingly.  Thanks for the info though hopefully other people don't run into this too and I'll remember to start with a linux distro for future use :)

Glad it works now.

I've spent the last few days working on ironing out the remaining kinks in rbssh and putting together a whole testing infrastructure to make sure this doesn't break again. I'm hoping to have a release out in a few days.

• Status:

  -	NeedInfo
  +	Confirmed

• Tags:

  -	Priority-Medium
  +	Priority-Critical
  +	Component-SSH
  +	Milestone-Release1.5.x

• Assigned to:

  +	chipx86

Fixed on release-1.5.x and master. This will be in for a 1.5.3 release shortly.

• Status:

  -	Confirmed
  +	Fixed