Summary

Fix problems with {% url %} overrides.

Review Request #2021 — Created Dec. 29, 2010 and submitted

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix problems with {% url %} overrides.

There were a couple problems with our override of the url templatetag, which
mostly stemmed from the fact that reviewboard.site.templatetags wasn't always
being called in every python instance.

Testing Done

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 1)

We'll want to copy the context and use the copy, as we don't want to mess with the parent context.

Change Summary:

Copy the Context object before updating it.

Diff:

Revision 2 (+7 -1)

Show changes

	reviewboard/__init__.py
	reviewboard/reviews/templatetags/reviewtags.py

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 2)
```
That'll still update context. Use context.copy().
```

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 2)

I can't reply because of the jsconsts bug, so here's my answer:

"context" here isn't a dict, it's a django.template.Context object, which doesn't have a copy() method, and also doesn't share storage in the same way that dicts do.

Ship it!

```
Ship It!
```