Add a ReviewRequest.get_display_id to generalize the ID field.

Review Request #2006 — Created Dec. 16, 2010 and submitted

Information

Review Board
master

Reviewers

Add a ReviewRequest.get_display_id to generalize the ID field.

In a lot of places we had to check both id and local_id in order to do something
interesting for the user (links, display on the template, etc). This change
generalizes that with a get_display_id() method, and fixes the ID printed in the
review request box and trophy calculation.
Ran unit tests, checked site display.
chipx86
  1. 
      
  2. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Can we make this a property?
  3. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Missing a period.
  4. No spaces in the {{ }}
  5. 
      
david
Review request changed
Diff:

Revision 2 (+79 -80)

Show changes

reviewboard/reviews/models.py
reviewboard/templates/reviews/review_flags.js
reviewboard/templates/reviews/trophy_box.html
reviewboard/webapi/resources.py
reviewboard/webapi/tests.py
chipx86
  1. Ship It!
    1. Heh, okay, so one-click Ship It is busted with the new API :)
  2. 
      
Loading...