1889: ValueError on reviewboard

com****@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 16, 2010 
What version are you running?

ReviewBoard 1.0.9 (with Django 1.2.1)

What's the URL of the page containing the problem?

users/(username)/show_submitted=(some_string)

What steps will reproduce the problem?
1. Just visit

What is the expected output? What do you see instead?

I caught the ValueError

 File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.9-py2.6.egg/reviewboard/reviews/datagrids.py", line 383, in load_extra_state
   self.show_submitted)) != 0

ValueError: invalid literal for int() with base 10: 'kvnzsuizcvav'



- In general case, show_submitted is not a string, but some bots(i.e google bots) are trying to visit our reviewboard with strange string, and server has broken down.
#1 jer****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Same thing happens for me. I'll open a pull request with a fix :)
#2 jer****@gmai***** (Google Code) (Is this you? Claim this profile.) 
There you go: https://github.com/reviewboard/reviewboard/pull/2
david
#3 david 
Please post this on http://reviews.reviewboard.org/
#4 jer****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Done.
david
#5 david 
Pushed to master as 3d03142. Thanks!
  • +Fixed