- Change Summary:
-
Update: - File descriptions now change correctly - Files are now deleted in a way more consistent with the new api Outstanding: - File comments do not get text - File "review request changed" events are not consistent
- Summary:
-
File attachment - preliminary reviewFile attachment - intermediate review
- Diff:
-
Revision 2 (+3021 -324)
File attachment - intermediate review
Review Request #1979 — Created Dec. 6, 2010 and submitted
Allows the attachment of downloadable files to a review request, using the new webapi. Outstanding issues - file comments do not update - review request changed comments give a bad link when linking to removed files
Manual testing and running the existing test suite with no errors or failures.
LA
LA
- Description:
-
~ Allows the attachment of downloadable files to a review request, using the new webapi.
~ Outstanding issues: ~ - file descriptions do not update ~ Allows the attachment of downloadable files to a review request, using the new webapi.
~ ~ Outstanding issues
- file comments do not update - review request changed comments give a bad link when linking to removed files
LA
-
uploadedFile.JPG: what the uploaded file looks likeuploaded filefileComment.jpg: comment on a file...comment on a file
LA
- Change Summary:
-
Added screenshots of the UI.
-
filereview.JPG: file review sfile review dialogfileupload.JPG: file upload dialgo
-
-
Two blank lines between these. Trailing whitespace should be removed. Also, imports are alphabetical, so the filemanager one should go before the reviews ones.
-
-
-
-
-
First line, immediately following the """, should be a one-line summary of the form, followed by a blank line, and then an optional description.
-
-
-
-
Should be spaces after : Also, this looks like it may be > 80 characters. If so, wrap widget= onto the next line.
-
-
-
-
-
-
-
-
-
-
-
-
This should use the @permalink decorator. See other instances of get_absolute_url, specifically Screenshot's.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
This can be better written as: if context_type in ('comment', 'screenshot_comment', 'file_comment'):
-
-
This will all need to be updated for the HTTP DELETE change. You can model it after how screenshots now do it.
-
-
-
-
-
-
-
-
-
Needs @webapi_check_local_site before other decorators. Also needs a @webapi_response_errors(DOES_NOT_EXIST, NOT_LOGGED_IN, PERMISSION_DENIED)
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
@webapi_check_local_site There's a pattern here :) Going to stop saying it now. Can you go through and make sure all others have it too?
-
Should include NOT_LOGGED_IN. Same with every other @webapi_response_errors containing PERMISSION_DENIED.
-
-