Fix diff loading when there's a draft.

Review Request #1963 — Created Dec. 2, 2010 and submitted

Information

Review Board
master

Reviewers

Fix diff loading when there's a draft.

I was using "review_request_details.get_absolute_url" as the diff base URL in
the view_diff.html template, which worked fine for published reviews but broke
when there was a draft, because ReviewRequestDraft doesn't have a
get_absolute_url implementation. I've changed it to plumb through a base_url
parameter, just like the chunk loading code.
Looked at a draft diff in a local site.
chipx86
  1. 
      
  2. reviewboard/diffviewer/views.py (Diff revision 1)
     
     
    Can we instead pass base_url in through extra_context? The diffviewer templates (unlike the code) is pretty heavily review request-specific, so I'd rather the diffviewer code not have to know about this particular detail.
  3. 
      
david
Review request changed
Change Summary:
Move base_url into extra_context.
chipx86
  1. 
      
  2.