Summary

One-click ship it.

Review Request #1883 — Created Oct. 29, 2010 and submitted

Information

Owner

kfquinn

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This patch adds a button in the top right that will instantly add a review that has the 'Ship It!' tag.  It will also have text 'Ship It!' in the text portion of the review.

Testing Done

Manual.  There were issues the publish() method and older reviews.  Not quite sure what was happening.

" invalid literal for int() with base 10: 'local_site_id' "

Mike mentioned David had worked on patch involving 'local_site_id'?

Reviews recently created had no issues (yet).

Screenshots

Ship It!

Do you have a backtrace for the local_site_id error?

reviewboard/htdocs/media/rb/js/reviews.js (Diff revision 1)
```
ws
```
reviewboard/htdocs/media/rb/js/reviews.js (Diff revision 1)
```
ws
```

I believe the issue for this is https://code.google.com/p/reviewboard/issues/detail?id=1640

Change Summary:

Removed spaces.
Could not replicate bug with 'local_site_id'... not sure how to proceed.

Diff:

Revision 2 (+2 -2)

Show changes

reviewboard/htdocs/media/rb/js/reviews.js

You seem to have uploaded a diff of only the whitespace changes. I need a diff of everything in order to actually apply it.