Summary

Sort interdiff revisions by revision number.

Review Request #180 — Created Nov. 28, 2007 and submitted

Information

Owner

ehuss

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The revisions listed in the interdiff selector are not sorted.  Sometimes, databases will return things in insert-order, but not always.

One way I was able to reliably reproduce this is to:
1. Post review.
2. Click Update Attached Diff, upload a new patch.
3. Before clicking Save, click "Update Attached Diff" again.  This effectively deletes the 2nd patch.
4. Click Save.
5. Click "Update Attached Diff" and upload a 4th patch.

Testing Done

Checked the interdiff selector before and after my change and it is now sorted correctly.

Screenshots

Sample broken page

Hah, nice catch.

Perhaps a better way to fix this so it can't crop up again is to set the order_by in the model info.

EH

ehuss Nov. 28, 2007, 6:35 a.m.
```
Agreed.
```

chipx86 Dec. 1, 2007, 1:14 p.m.

Just committed the order_by version of this. Let me know if it continues to break for you.