Summary

Adding more extension tests to Djblets

Review Request #1725 — Created July 30, 2010 and submitted

Information

Owner

mike_conley

Repository

Djblets

Branch

extensions

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This patch relies on http://reviews.reviewboard.org/r/1687/

Just added a few tests for the ExtensionManager and the Hooks.

A lot of the ExtensionManager methods aren't tested yet.  Things like the Manager calling syncdb are making things kind of difficult.

Testing Done

All tests pass.

djblets/extensions/base.py (Diff revision 1)

I'm using a single _ here because Python won't let me override methods that start with __.

djblets/extensions/base.py (Diff revision 1)

Maybe rename this to "get_extension_entrypoints", without the "_". Technically, I don't think "_" functions are meant to be overwritten.

Can you also document the purpose for this function?

djblets/extensions/tests.py (Diff revision 1)

These docblocks will all be shown for the unit tests, so they should ideally be a bit shorter. More detailed information can be in standard comments. Also, I think if they wrap, it displays them wrong or cuts them off.

djblets/extensions/tests.py (Diff revision 1)
```
Blank line should be removed.
```
djblets/extensions/tests.py (Diff revision 1)
```
Should use assertEqual
```
djblets/extensions/tests.py (Diff revision 1)
```
Should use assertEqual
```

Change Summary:

Thanks for the feedback!  Updated.

Diff:

Revision 2 (+149 -15)

Show changes

	djblets/extensions/base.py
	djblets/extensions/tests.py

Ship it!

```
Committed to extensions (cb5ec89)
```