Add basic issue tracking to DiffComments and ScreenshotComments
Review Request #1718 — Created July 23, 2010 and submitted — Latest diff uploaded
The patch does the following: -Adds an issue_opened and issue_status field in both Comment (for Diffs) and ScreenshotComment. -Adds a BaseComment resource for DiffComment and ScreenshotComment resources to inherit from, which allows for changing Issue status -Adds a checkbox to the comment dialog to open an issue -Adds UI for displaying (and for review request submitters, manipulating) Issue statuses.
Added some WebAPI tests to check issue_opened/status logic. All tests pass.
Diff Revision 7 (Latest)
orig
1
2
3
4
5
6
7
| reviewboard/htdocs/media/rb/css/reviews.css | |||
|---|---|---|---|
| Revision 70b9b400c01d96a2ece0ae0810c495099dfda551 | New Change | ||
| 884 lines | |||
| 885 | 885 | ||
| 886 |
#comment-detail #review_comments ul li h2 .actions a:hover { |
886 |
#comment-detail #review_comments ul li h2 .actions a:hover { |
| 887 |
background-color: #F6F6F6; |
887 |
background-color: #F6F6F6; |
| 888 |
}
|
888 |
}
|
| 889 | 889 | ||
| 890 |
.issue-state { |
||
| 891 |
font-size: 90%; |
||
| 892 |
font-weight: bold; |
||
| 893 |
padding-bottom: 5px; |
||
| 894 |
padding-left: 25px; |
||
| 895 |
padding-top: 5px; |
||
| 896 |
}
|
||
| 897 | |||
| 898 |
.issue-state.dropped { |
||
| 899 |
background: url('../images/cancel_grey.png') #E5E5E5 no-repeat 5px 50%; |
||
| 900 |
}
|
||
| 901 | |||
| 902 |
.issue-state.open { |
||
| 903 |
background: url('../images/warning.png') #FFFF7C no-repeat 5px 50%; |
||
| 904 |
border: 2px solid #FF0000; |
||
| 905 |
}
|
||
| 906 | |||
| 907 |
.issue-state.resolved { |
||
| 908 |
background: url('../images/tick.png') #FAFAFA no-repeat 5px 50%; |
||
| 909 |
}
|
||
| 910 | |||
| 911 |
.issue-button { |
||
| 912 |
border: 1px outset black; |
||
| 913 |
font-size: 90%; |
||
| 914 |
font-weight: bold; |
||
| 915 |
margin-left: 5px; |
||
| 916 |
}
|
||
| 917 | |||
| 890 | 918 | ||
| 891 |
/****************************************************************************
|
919 |
/****************************************************************************
|
| 892 |
* Banners
|
920 |
* Banners
|
| 893 |
****************************************************************************/
|
921 |
****************************************************************************/
|
| 894 |
#discard-banner, |
922 |
#discard-banner, |
| 99 lines | |||
| reviewboard/htdocs/media/rb/images/cancel_grey.png |
|---|
| reviewboard/htdocs/media/rb/images/tick.png |
|---|
| reviewboard/htdocs/media/rb/images/warning.png |
|---|
| reviewboard/htdocs/media/rb/js/datastore.js |
|---|
| reviewboard/htdocs/media/rb/js/reviews.js |
|---|
| reviewboard/reviews/models.py |
|---|
| reviewboard/reviews/evolutions/__init__.py |
|---|
| reviewboard/reviews/evolutions/add_issues_to_comments.py |
|---|
| reviewboard/reviews/templatetags/reviewtags.py |
|---|
| reviewboard/templates/reviews/comment_issue.html |
|---|
| reviewboard/templates/reviews/comments_dlg.html |
|---|
| reviewboard/templates/reviews/review_detail.html |
|---|
| reviewboard/templates/reviews/review_reply_section.html |
|---|
| reviewboard/webapi/resources.py |
|---|
| reviewboard/webapi/tests.py |
|---|