1541: Multibyte characters in diff fragments are broken with syntax highlighting.
- Fixed
- Review Board
KoRoN.*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
chipx86 | |
June 14, 2010 |
I use reviewboard 1.5 beta1. I manage some repositries which include many Japanese multibyte characters. Those characters in diff fragments view are broken because of Pygment (syntax highlighting library) doesn't know its input encoding. I create a patch to fix this problem. Please check it.
Can you submit this to http://reviews.reviewboard.org/? All patches must go through our standard code review process.
-
+ Confirmed -
+ Component-DiffViewer + Milestone-Release1.5
I submit a review as http://reviews.reviewboard.org/r/1639/. But the diff can't be seen on reviewboard system. What happen about it? Is it another bug?
No I didn't. I had made it by "git diff HEAD".
Try using post-review. Most likely, it's broken due to your diff using a short SHA1. Long SHA1s are required. post-review will do this for you, or you can pass --full-index to git diff. There's a bug filed for providing a better error message for this case.
Thank you chipx86! I could post a new diff file which be generated with '--ful-index', and it seems good in diff viewer.