Summary

New option in post-review: --revision-range

Review Request #162 — Created Oct. 1, 2007 and discarded

Information

Owner

philn

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This patch adds a new method to the SCMClient: diff_between_revisions(), implemented for SVNClient only (I have now P4 knowledge, sorry).

So you can use the revision-range option like this: --revision-range 200:300
or even --revision-range 200 (will diff between rev 200 and HEAD in svn).

Testing Done

trunk/reviewboard/contrib/tools/post-review (Diff revision 1)

It doesn't look like we really need this anymore, do we?

trunk/reviewboard/contrib/tools/post-review (Diff revision 1)

Missing space after "given", and shouldn't this have a + at the end?

trunk/reviewboard/contrib/tools/post-review (Diff revision 1)

Trailing whitespace.

philn Oct. 5, 2007, 4:15 a.m.

Thanks for your comments! I made a new version of the patch but I can't upload it, I get the "unable to parse server response" error :(