post-review parameter to reopen discarded review

 






 

 


  Review Request #1517
  —
  Created April 19, 2010 and submitted

 


















 

  

   Information

  





 
 

  jan.koprowski
 









 
 

  RBTools
 









 
 

  master
 









 
 

  1607
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
post-review have additional parameter --reopen which reopen discarded review.

 








  


 
 

  

 







 









 





  








 









 






  

 








 














 





 

  

   





 CK





   

   







  

 



 

  


   

   

    
 
cking


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Look OK to me
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       rbtools/postreview.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    Probably don't need this debug info.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      There is information about publishing so why a not about Reopening?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Fair enough.
      
 
      

      3. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       rbtools/postreview.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    I believe this will fail if it's not closed. Is this okay? I think we probably want to warn but not fail if the review request isn't actually closed.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I will check this. Should I check state of review_request before if needed data is available? 
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I think it's okay to just make the call and check the resulting error. We do this for the initial review request creation with Perforce change numbers. If it's already taken, we silently ignore and call the update_changenum function.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      So what I should change?
      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      Just check for an error response and ignore it.
      
 
      

      5. 



    5. 
 
 
      
 
      
  
 
      
 
      
  
      Actually, reopen is just a no-op if it's PENDING_REVIEW.
      
 
      

      6. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




jan.koprowski




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  









  

   

    Change Summary:
   

   

    
Changed according tips.

   

  








  

   

    Diff:
   

   

    
 Revision 2 (+20)
Show changes
 
    rbtools/postreview.py 
 

   

  












  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Committed as 43b2947. Thanks!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3.