Summary

Fix `rbt patch` applying patches with binary files from pre-6.0

Review Request #15005 — Created April 4, 2026 and updated April 4, 2026, 9:48 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

When a review request including binary files was posted with older
versions of RBTools (or if uploading of binary files did not occur, for
example, for very large files), rbt patch would crash attempting to
access the non-existent FileAttachment.

This change makes it so we check if the attachment exists first, and
adds a variety of tests for the rbt patch command to test various
aspects of binary file patching.

Testing Done


Ran unit tests.

Commits

Summary	ID
Fix `rbt patch` applying patches with binary files from pre-6.0 When a review request including binary files was posted with older versions of RBTools (or if uploading of binary files did not occur, for example, for very large files), `rbt patch` would crash attempting to access the non-existent FileAttachment. This change makes it so we check if the attachment exists first, and adds a variety of tests for the `rbt patch` command to test various aspects of binary file patching. Testing Done: - Ran unit tests.	vrllmnoqwmultrvovuwnrrymqtyksllr

Summary

Fix `rbt patch` applying patches with binary files from pre-6.0

When a review request including binary files was posted with older versions of RBTools (or if uploading of binary files did not occur, for example, for very large files), `rbt patch` would crash attempting to access the non-existent FileAttachment. This change makes it so we check if the attachment exists first, and adds a variety of tests for the `rbt patch` command to test various aspects of binary file patching. Testing Done: - Ran unit tests.

vrllmnoqwmultrvovuwnrrymqtyksllr

flake8 passed.

JSHint passed.