Fix display of new files deleted in a parent diff.
Review Request #14996 — Created April 1, 2026 and submitted — Latest diff uploaded
While debugging another issue, I discovered that if a diff contains a
"new file" but has a parent diff that previously deleted that file, it
would show in two-column mode with the left-hand side totally empty.This traced back to an old fix done way back in 2012, back when we only
had asource_revisionfield which was overloaded between both the diff
and parent diff. That was fixed in 3.0.19, but theis_new_file
calculation still completely turned it off if we had a parent diff
present at all.I've changed this so that if we have a modern
parent_source_revision,
we allow ourselves to trust thenewfileflag.
- Verified that this situation now correctly appeared as a new file in
the diff viewer. - Ran unit tests.