Summary

Fix crashes when attempting to download newly-added empty files.

Review Request #14995 — Created April 2, 2026 and submitted April 2, 2026, 2:34 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When a diff contained a newly-added empty file, the resulting diff

entry would include a download link, which then crashed with a

PatchError. We've been getting these error emails a lot as bots have

crawled our server.
This change applies two fixes:

We no longer show a download link for new empty files.
If somehow the download endpoint is accessed anyway, we catch

PatchError and return a 404.

Testing Done


Verified that newly-added empty files no longer contained a download

  link.
Ran unit tests.

Commits

Summary	ID
Fix crashes when attempting to download newly-added empty files. When a diff contained a newly-added empty file, the resulting diff entry would include a download link, which then crashed with a `PatchError`. We've been getting these error emails a lot as bots have crawled our server. This change applies two fixes: - We no longer show a download link for new empty files. - If somehow the download endpoint is accessed anyway, we catch `PatchError` and return a 404. Testing Done: - Verified that newly-added empty files no longer contained a download link. - Ran unit tests.	qsnylsomrlvksypomzxpuoxlmwkmptly

Summary

Fix crashes when attempting to download newly-added empty files.

When a diff contained a newly-added empty file, the resulting diff entry would include a download link, which then crashed with a `PatchError`. We've been getting these error emails a lot as bots have crawled our server. This change applies two fixes: - We no longer show a download link for new empty files. - If somehow the download endpoint is accessed anyway, we catch `PatchError` and return a 404. Testing Done: - Verified that newly-added empty files no longer contained a download link. - Ran unit tests.

qsnylsomrlvksypomzxpuoxlmwkmptly

Issues