Summary

Restore symlinks in .npm-workspaces after the build completes.

Review Request #14984 — Created March 31, 2026 and submitted March 31, 2026, 10:19 p.m.

Information

Owner

chipx86

Repository

buildthings

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

When performing a build with NPM enabled and Python-based NPM modules
set, symlinks in .npm-workspaces would get set to the location within
the newly-installed module. That would become a dangling symlink, since
that module was installed in the isolated build environment, and if
there was an existing symlink pointing to a dev tree, it would be lost.

Now, any symlinks in .npm-workspaces that will be overridden will be
restored after a build, whether it completes successfully or errors out.
This should help to avoid confusing runtime and build issues after a new
build.

Testing Done

Tested a build with Review Board and watched the symlinks in the directory.
Verified that the symlinks were changed during the build and restored
after.

Commits

Summary	ID
Restore symlinks in .npm-workspaces after the build completes. When performing a build with NPM enabled and Python-based NPM modules set, symlinks in `.npm-workspaces` would get set to the location within the newly-installed module. That would become a dangling symlink, since that module was installed in the isolated build environment, and if there was an existing symlink pointing to a dev tree, it would be lost. Now, any symlinks in `.npm-workspaces` that will be overridden will be restored after a build, whether it completes successfully or errors out. This should help to avoid confusing runtime and build issues after a new build.	86ba91a7ba4aafcc704c8d55d4f62f2bdc499883

Summary

Restore symlinks in .npm-workspaces after the build completes.

When performing a build with NPM enabled and Python-based NPM modules set, symlinks in `.npm-workspaces` would get set to the location within the newly-installed module. That would become a dangling symlink, since that module was installed in the isolated build environment, and if there was an existing symlink pointing to a dev tree, it would be lost. Now, any symlinks in `.npm-workspaces` that will be overridden will be restored after a build, whether it completes successfully or errors out. This should help to avoid confusing runtime and build issues after a new build.

86ba91a7ba4aafcc704c8d55d4f62f2bdc499883

Issues

Description	From	Last Updated
Instead of a global, how about if we return the dict from _rebuild_npm_workspaces?	david	March 31, 2026, 3:20 p.m.

flake8 passed.

JSHint passed.

buildthings/backend.py (Diff revision 1)

The issue has been resolved. Show all issues

Instead of a global, how about if we return the dict from _rebuild_npm_workspaces?

Change Summary:

Updated to return the mapping instead of using a global, and re-tested.

Commits:

	Summary	ID
	Restore symlinks in .npm-workspaces after the build completes. When performing a build with NPM enabled and Python-based NPM modules set, symlinks in `.npm-workspaces` would get set to the location within the newly-installed module. That would become a dangling symlink, since that module was installed in the isolated build environment, and if there was an existing symlink pointing to a dev tree, it would be lost. Now, any symlinks in `.npm-workspaces` that will be overridden will be restored after a build, whether it completes successfully or errors out. This should help to avoid confusing runtime and build issues after a new build.	e64e5221555b635df444d818687b760467ad89af
	Restore symlinks in .npm-workspaces after the build completes. When performing a build with NPM enabled and Python-based NPM modules set, symlinks in `.npm-workspaces` would get set to the location within the newly-installed module. That would become a dangling symlink, since that module was installed in the isolated build environment, and if there was an existing symlink pointing to a dev tree, it would be lost. Now, any symlinks in `.npm-workspaces` that will be overridden will be restored after a build, whether it completes successfully or errors out. This should help to avoid confusing runtime and build issues after a new build.	86ba91a7ba4aafcc704c8d55d4f62f2bdc499883

Diff:

Revision 2 (+96 -16)

Show changes

	NEWS.rst
	buildthings/backend.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (316f83e)