Summary

Fix the header above reviews/replies and make it a new component.

Review Request #14971 — Created March 26, 2026 and updated March 27, 2026, 6:26 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Instead of making the situation worse, this change introduces a new
rb-c-discussion-header component that can be used in each of these
areas. It's responsible for showing the author information or title, the
timestamp, and an optional avatar and "new updates" icon.

This can also be put in compact mode, which places the timestamp below
the name. Replies enable this and avatars, whereas the review headers do
not.

A Storybook story has been added to help document and maintain this
component.

Testing Done

Tested this in mobile and desktop modes on all review request entry
boxes and in replies (published, existing draft, and new draft).

Tested in light and dark modes.

All Python and JavaScript unit tests pass.

Commits

Summary	ID
Fix the header above reviews/replies and make it a new component. The work on user badges regressed some of the display of the header area at the top of reviews and in comments. This wasn't helped by the fact that this is some of the oldest CSS in the codebases, and it's a huge rats nest. Fixing this meant fixing it in multiple places and then dealing with overrides. Instead of making the situation worse, this change introduces a new `rb-c-discussion-header` component that can be used in each of these areas. It's responsible for showing the author information or title, the timestamp, and an optional avatar and "new updates" icon. This can also be put in compact mode, which places the timestamp below the name. Replies enable this and avatars, whereas the review headers do not. A Storybook story has been added to help document and maintain this component.	79e8306c69a17df48ad9aa58c737e23f8c5ce1d1

Summary

Fix the header above reviews/replies and make it a new component.

The work on user badges regressed some of the display of the header area at the top of reviews and in comments. This wasn't helped by the fact that this is some of the oldest CSS in the codebases, and it's a huge rats nest. Fixing this meant fixing it in multiple places and then dealing with overrides. Instead of making the situation worse, this change introduces a new `rb-c-discussion-header` component that can be used in each of these areas. It's responsible for showing the author information or title, the timestamp, and an optional avatar and "new updates" icon. This can also be put in compact mode, which places the timestamp below the name. Replies enable this and avatars, whereas the review headers do not. A Storybook story has been added to help document and maintain this component.

79e8306c69a17df48ad9aa58c737e23f8c5ce1d1

Files

Issues

Description	From	Last Updated
Looks like reviewboard/static/rb/js/reviewRequestPage/views/tests/baseStatusUpdatesEntryViewTests.es6.js also needs to be updated for this change.	david	March 27, 2026, 6:26 p.m.
Typo: area-label -> aria-label	david	March 27, 2026, 1:30 p.m.
header-details and summary are no longer used at all in templates/reviews/entries/base.html (and I don't see it elsewhere in the codebase). …	david	March 27, 2026, 1:35 p.m.
__title is a grid child, so this property does nothing.	david	March 27, 2026, 1:35 p.m.
Do we not need to pass timestamp in the way that we were doing before?	david	March 27, 2026, 1:35 p.m.
Now that this is fully removed, I see that it's removing the responsive rules that switched to vertical stacking. Can …	david	March 27, 2026, 6:26 p.m.

flake8 passed.

JSHint passed.

docs/stories/components/reviews/discussion-header.stories.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: area-label -> aria-label
```

reviewboard/static/rb/css/pages/reviews.less (Diff revision 1)

The issue has been resolved. Show all issues

header-details and summary are no longer used at all in templates/reviews/entries/base.html (and I don't see it elsewhere in the codebase). This gap doesn't seem to make sense, and in fact we might want to just remove this CSS entirely now.

chipx86 March 27, 2026, 1:38 p.m.

This was part of the original change that led to this work. I had code in my stash to remove all this that just got missed.

reviewboard/static/rb/css/ui/discussion-header.less (Diff revision 1)
The issue has been resolved. Show all issues
```
__title is a grid child, so this property does nothing.
```

reviewboard/templates/reviews/review_reply.html (Diff revision 1)

The issue has been resolved. Show all issues

Do we not need to pass timestamp in the way that we were doing before?

chipx86 March 27, 2026, 1:38 p.m.

With timestamp as timestamp? No, I'm not entirely sure why we had that. blocktrans strings will make use of existing variables as long as they're not any more simple than a bare local variable reference.

Change Summary:


Removed unused styles.
area-label -> aria-label.

Commits:

	Summary	ID
	Fix the header above reviews/replies and make it a new component. The work on user badges regressed some of the display of the header area at the top of reviews and in comments. This wasn't helped by the fact that this is some of the oldest CSS in the codebases, and it's a huge rats nest. Fixing this meant fixing it in multiple places and then dealing with overrides. Instead of making the situation worse, this change introduces a new `rb-c-discussion-header` component that can be used in each of these areas. It's responsible for showing the author information or title, the timestamp, and an optional avatar and "new updates" icon. This can also be put in compact mode, which places the timestamp below the name. Replies enable this and avatars, whereas the review headers do not. A Storybook story has been added to help document and maintain this component.	10542b882656cc7f9ffee23b3a4f9ad239290d8f
	Fix the header above reviews/replies and make it a new component. The work on user badges regressed some of the display of the header area at the top of reviews and in comments. This wasn't helped by the fact that this is some of the oldest CSS in the codebases, and it's a huge rats nest. Fixing this meant fixing it in multiple places and then dealing with overrides. Instead of making the situation worse, this change introduces a new `rb-c-discussion-header` component that can be used in each of these areas. It's responsible for showing the author information or title, the timestamp, and an optional avatar and "new updates" icon. This can also be put in compact mode, which places the timestamp below the name. Replies enable this and avatars, whereas the review headers do not. A Storybook story has been added to help document and maintain this component.	79e8306c69a17df48ad9aa58c737e23f8c5ce1d1

Diff:

Revision 2 (+842 -194)

Show changes

	docs/stories/components/reviews/discussion-header.stories.ts
	reviewboard/static/rb/css/bundles/common.less
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/css/ui/discussion-header.less
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js
	reviewboard/templates/reviews/review_reply.html
	reviewboard/templates/reviews/entries/base.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

An issue was opened. Show all issues

Looks like reviewboard/static/rb/js/reviewRequestPage/views/tests/baseStatusUpdatesEntryViewTests.es6.js also needs to be updated for this change.

reviewboard/static/rb/css/pages/reviews.less (Diff revision 2)

An issue was opened. Show all issues

Now that this is fully removed, I see that it's removing the responsive rules that switched to vertical stacking. Can you test the header on mobile?