• 
  
    
 
    
 
    

    



    
    
    
    
     
    






    
 
    


 
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix bugs caused by UglifyJS+Backbone 1.6.1
    
 
    

    



 
    
 
    

  Review Request #14960
  —
  Created March 25, 2026 and discarded  — Latest diff uploaded 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Djblets
 
    

    





    
 
 
    
  release-5.2.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  djblets
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    As discussed in /r/14959, the combination of UglifyJS and Backbone 1.6.1
    
has a bug that aliases arguments in a way that affects model
    
construction during parsing. The Djblets codebase had two places that
    
were doing the same thing, causing the conditions UI to break. This
    
change fixes those up.
    
 
    

    





  

    
 
 
    
  
    Built and minified JS, and then copied it into a 7.0.5 docker container.
    
Verified that the fix worked correctly.
    
 
    

    




 
    

    





    
 
    









 




 
    

    




   
    
    
    
    
    
    
    
    

    
    
      
    Commits
    
      
    
        
      
    
    
    

    
    

      
    Files