Summary

Fix bugs caused by UglifyJS+Backbone 1.6.1

Review Request #14960 — Created March 25, 2026 and discarded March 25, 2026, 8:16 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.2.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

As discussed in /r/14959, the combination of UglifyJS and Backbone 1.6.1
has a bug that aliases arguments in a way that affects model
construction during parsing. The Djblets codebase had two places that
were doing the same thing, causing the conditions UI to break. This
change fixes those up.

Testing Done

Built and minified JS, and then copied it into a 7.0.5 docker container.
Verified that the fix worked correctly.

Commits

Summary	ID
Fix bugs caused by UglifyJS+Backbone 1.6.1 As discussed in /r/14959, the combination of UglifyJS and Backbone 1.6.1 has a bug that aliases `arguments` in a way that affects model construction during parsing. The Djblets codebase had two places that were doing the same thing, causing the conditions UI to break. This change fixes those up. Testing Done: Built and minified JS, and then copied it into a 7.0.5 docker container. Verified that the fix worked correctly.	sosovzppomxppqrunomxnzxxvtmypykt

Summary

Fix bugs caused by UglifyJS+Backbone 1.6.1

As discussed in /r/14959, the combination of UglifyJS and Backbone 1.6.1 has a bug that aliases `arguments` in a way that affects model construction during parsing. The Djblets codebase had two places that were doing the same thing, causing the conditions UI to break. This change fixes those up. Testing Done: Built and minified JS, and then copied it into a 7.0.5 docker container. Verified that the fix worked correctly.

sosovzppomxppqrunomxnzxxvtmypykt

flake8 passed.

JSHint passed.

Change Summary:: Posted from the wrong tree and inherited a bad branch name.
Branch:: release-6.x
release-5.2.x

Status:: Discarded