Summary

Split out rbext from Review Board into a new package.

Review Request #14955 — Created March 24, 2026 and updated March 24, 2026, 8:13 p.m.

Information

Owner

chipx86

Repository

rbext

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

This introduces a dedicated package for rbext, the Review Board

extension command line tool. This is a straight port of what's in

the Review Board 8 tree, but with modern typing and code cleanup

integrated with it, and deprecations removed.
The plan is to have a standalone tool not dependent on any given version

of Review Board that can be used not only to create and test packages,

but also to build packages to distribute.
To accomplish building packages, an upcoming change will introduce a

Python build backend, rbext.build.backend, built on top of

buildthings. This will handle a pre-build phase involving asset

generation and static media infrastructure setup, and then perform a

standard python -m build.
For now, everything that's in here is more or less what was in

reviewboard/cmdline/rbext.py, but split up and cleaned up. This will

be the foundation for future work.

Testing Done

Tested creating a tree and then running unit tests on it.

Commits

Summary	ID
Split out rbext from Review Board into a new package. This introduces a dedicated package for `rbext`, the Review Board extension command line tool. This is a straight port of what's in the Review Board 8 tree, but with modern typing and code cleanup integrated with it, and deprecations removed. The plan is to have a standalone tool not dependent on any given version of Review Board that can be used not only to create and test packages, but also to build packages to distribute. To accomplish building packages, an upcoming change will introduce a Python build backend, `rbext.build.backend`, built on top of `buildthings`. This will handle a pre-build phase involving asset generation and static media infrastructure setup, and then perform a standard `python -m build`. For now, everything that's in here is more or less what was in `reviewboard/cmdline/rbext.py`, but split up and cleaned up. This will be the foundation for future work.	ab47e04f18fc550aa978c94b5d09a3071b7f884c

Summary

Split out rbext from Review Board into a new package.

This introduces a dedicated package for `rbext`, the Review Board extension command line tool. This is a straight port of what's in the Review Board 8 tree, but with modern typing and code cleanup integrated with it, and deprecations removed. The plan is to have a standalone tool not dependent on any given version of Review Board that can be used not only to create and test packages, but also to build packages to distribute. To accomplish building packages, an upcoming change will introduce a Python build backend, `rbext.build.backend`, built on top of `buildthings`. This will handle a pre-build phase involving asset generation and static media infrastructure setup, and then perform a standard `python -m build`. For now, everything that's in here is more or less what was in `reviewboard/cmdline/rbext.py`, but split up and cleaned up. This will be the foundation for future work.

ab47e04f18fc550aa978c94b5d09a3071b7f884c

Issues

Description	From	Last Updated
'rbext.commands.build.BuildCommand' imported but unused Column: 1 Error code: F401	reviewbot	March 24, 2026, 2:57 p.m.
'rbext.commands.inspect.InspectCommand' imported but unused Column: 1 Error code: F401	reviewbot	March 24, 2026, 2:57 p.m.
https://www.youtube.com/watch?v=QRdRPLq5fzA	david	March 24, 2026, 8:13 p.m.
This will include only rbext but not rbext.commands or rbext.commands.base. I think we want: [tool.setuptools.packages.find] where = ['.'] namespaces = …	david	March 24, 2026, 8:13 p.m.
I know we don't have much in here, but we should probably have a __future__.annotations import anyway.	david	March 24, 2026, 8:13 p.m.
This file needs a __future__.annotations import.	david	March 24, 2026, 8:13 p.m.
We should type this as tuple[int, int, int, int, str, int, bool], otherwise it will be implicitly typed as literals …	david	March 24, 2026, 8:13 p.m.
"the" is duplicated here.	david	March 24, 2026, 8:13 p.m.
This should be an empty string I think.	david	March 24, 2026, 8:13 p.m.
Should be rbext.commands.base.errors.CommandError	david	March 24, 2026, 8:13 p.m.
using alphanumeric... what?	david	March 24, 2026, 8:13 p.m.
This comes from old code, but we shouldn't have "nose" anywhere in new stuff.	david	March 24, 2026, 8:13 p.m.
Can we use f-strings here?	david	March 24, 2026, 8:13 p.m.
rb-site -> rbext	david	March 24, 2026, 8:13 p.m.

flake8 failed.

JSHint passed.

flake8

rbext/main.py (Diff revision 1)

The issue has been resolved. Show all issues

'rbext.commands.build.BuildCommand' imported but unused

Column: 1
Error code: F401

rbext/main.py (Diff revision 1)

The issue has been resolved. Show all issues

'rbext.commands.inspect.InspectCommand' imported but unused

Column: 1
Error code: F401

Change Summary:

Removed imports for in-development commands.

Commits:

	Summary	ID
	Split out rbext from Review Board into a new package. This introduces a dedicated package for `rbext`, the Review Board extension command line tool. This is a straight port of what's in the Review Board 8 tree, but with modern typing and code cleanup integrated with it, and deprecations removed. The plan is to have a standalone tool not dependent on any given version of Review Board that can be used not only to create and test packages, but also to build packages to distribute. To accomplish building packages, an upcoming change will introduce a Python build backend, `rbext.build.backend`, built on top of `buildthings`. This will handle a pre-build phase involving asset generation and static media infrastructure setup, and then perform a standard `python -m build`. For now, everything that's in here is more or less what was in `reviewboard/cmdline/rbext.py`, but split up and cleaned up. This will be the foundation for future work.	02fc6b50b597201cbb6f4ac37541e32d75c39fe1
	Split out rbext from Review Board into a new package. This introduces a dedicated package for `rbext`, the Review Board extension command line tool. This is a straight port of what's in the Review Board 8 tree, but with modern typing and code cleanup integrated with it, and deprecations removed. The plan is to have a standalone tool not dependent on any given version of Review Board that can be used not only to create and test packages, but also to build packages to distribute. To accomplish building packages, an upcoming change will introduce a Python build backend, `rbext.build.backend`, built on top of `buildthings`. This will handle a pre-build phase involving asset generation and static media infrastructure setup, and then perform a standard `python -m build`. For now, everything that's in here is more or less what was in `reviewboard/cmdline/rbext.py`, but split up and cleaned up. This will be the foundation for future work.	ab47e04f18fc550aa978c94b5d09a3071b7f884c

Diff:

Revision 2 (+3370 -2)

Show changes

	.gitignore
	README.rst
	pyproject.toml
	rbext/__init__.py
	rbext/_version.py
	rbext/errors.py
	rbext/main.py
	rbext/commands/__init__.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

pyproject.toml (Diff revision 2)
An issue was opened. Show all issues
```
https://www.youtube.com/watch?v=QRdRPLq5fzA
```

pyproject.toml (Diff revision 2)

An issue was opened. Show all issues

This will include only rbext but not rbext.commands or rbext.commands.base. I think we want:
[tool.setuptools.packages.find]

where = ['.']

namespaces = false

rbext/__init__.py (Diff revision 2)

An issue was opened. Show all issues

I know we don't have much in here, but we should probably have a __future__.annotations import anyway.

rbext/_version.py (Diff revision 2)
An issue was opened. Show all issues
```
This file needs a __future__.annotations import.
```

rbext/_version.py (Diff revision 2)

An issue was opened. Show all issues

We should type this as tuple[int, int, int, int, str, int, bool], otherwise it will be implicitly typed as literals and comparisons will warn.

rbext/_version.py (Diff revision 2)
An issue was opened. Show all issues
```
"the" is duplicated here.
```
rbext/commands/base/commands.py (Diff revision 2)
An issue was opened. Show all issues
```
This should be an empty string I think.
```
rbext/commands/base/commands.py (Diff revision 2)
An issue was opened. Show all issues
```
Should be rbext.commands.base.errors.CommandError
```
rbext/commands/create.py (Diff revision 2)
An issue was opened. Show all issues
```
using alphanumeric... what?
```

rbext/commands/test.py (Diff revision 2)

An issue was opened. Show all issues

This comes from old code, but we shouldn't have "nose" anywhere in new stuff.

rbext/main.py (Diff revision 2)
An issue was opened. Show all issues
```
Can we use f-strings here?
```
rbext/main.py (Diff revision 2)
An issue was opened. Show all issues
```
rb-site -> rbext
```