Summary

Modernize error handling.

Review Request #14913 — Created March 17, 2026 and submitted March 18, 2026, 8:06 a.m.

Information

Owner

david

Repository

rb-gateway

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-gateway

People

Description

This change makes a couple changes to the way errors are handled in

rb-gateway:

Replaced fmt.Errorf("...: %s", err.Error()) with

fmt.Errorf("...: %w", err)
Fixed string-based comparison of "object not found" errors to instead

  use errors.Is(...)

Testing Done

Ran unit tests.

Commits

Summary	ID
Modernize error handling. This change makes a couple changes to the way errors are handled in rb-gateway: - Replaced `fmt.Errorf("...: %s", err.Error())` with `fmt.Errorf("...: %w", err)` - Fixed string-based comparison of "object not found" errors to instead use `errors.Is(...)` Testing Done: Ran unit tests.	kptpzzuwkrrmlvupvqvxksumwnrswptq

Issues

Description	From	Last Updated
Just flagging to check if you intentionally got rid of the trailing newline in the error message here.	maubin	March 18, 2026, 8:02 a.m.

flake8 passed.

JSHint passed.

Ship it!

api/tokens/memory_store.go (Diff revision 1)

The issue has been resolved. Show all issues

Just flagging to check if you intentionally got rid of the trailing newline in the error message here.

david March 18, 2026, 8:03 a.m.

Was intentional but I missed another one just below.

Commits:

	Summary	ID
	Modernize error handling. This change makes a couple changes to the way errors are handled in rb-gateway: - Replaced `fmt.Errorf("...: %s", err.Error())` with `fmt.Errorf("...: %w", err)` - Fixed string-based comparison of "object not found" errors to instead use `errors.Is(...)` Testing Done: Ran unit tests.	kptpzzuwkrrmlvupvqvxksumwnrswptq
	Modernize error handling. This change makes a couple changes to the way errors are handled in rb-gateway: - Replaced `fmt.Errorf("...: %s", err.Error())` with `fmt.Errorf("...: %w", err)` - Fixed string-based comparison of "object not found" errors to instead use `errors.Is(...)` Testing Done: Ran unit tests.	kptpzzuwkrrmlvupvqvxksumwnrswptq

Diff:

Revision 2 (+10 -10)

Show changes

	api/tokens/memory_store.go
	repositories/git.go
	repositories/hooks/webhook.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Completed
Change Summary:: Pushed to master (e224ebb)