flake8
passed.
JSHint
passed.
Promote some mandatory properties from cert storage backends to base.
Review Request #14898 — Created March 12, 2026 and updated
There are some important variables in the SSL/TLS cert storage backends
that are currently locked into the file storage backend. This promotes
the following from that backend into the base classes and adds
validation during construction:
BaseStoredCertificate.hostnameBaseStoredCertificate.portBaseStoredCertificateBundle.nameBaseStoredCertificateFingerprints.hostnameBaseStoredCertificateFingerprints.port
Unit tests pass.
| Summary | ID |
|---|---|
| 58cfc367f643a0448defcfbe8aa0157d64f1598d |
| Description | From | Last Updated |
|---|---|---|
|
I think we can get rid of the "These will be mandatory in Review Board 9", they're only mandatory if … |
 maubin
|
|
|
Copy/pasteo: hostname -> port |
 david
|
|
|
Can you add a Raises section in the docs for these. |
maubin
|
|
|
Do we need to go through a release cycle where these are optional and say "These will be mandatory in … |
maubin
|
|
|
Copy/pasteo: hostname -> port |
david
|
|
|
There are double spaces on these (space at the end of one line and the beginning of the next) |
david
|
|
|
This should end with )> |
david
|
|
|
This test says "missing hostname" but your certificate has a hostname, so it's testing a missing port. We should probably … |
david
|
-
-
I think we can get rid of the "These will be mandatory in Review Board 9", they're only mandatory if certificate is not set. And if we get rid of that we can merge this with the above bullet point. I guess you can say "These will be mandatory if certificate is not provided".
-
-
Do we need to go through a release cycle where these are optional and say "These will be mandatory in Review Board X" before we make them mandatory?
