Summary

Modernize typing for reviewboard.certs.

Review Request #14897 — Created March 11, 2026 and updated March 12, 2026, 7:35 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This updates the reviewboard.certs codebase to use modern typing in
preparation for upcoming work to integrate this into the rest of
Review Board.

It's a pretty routine change, and gets rid of a number of top-level
imports.

Testing Done

Unit tests pass.

Commits

Summary	ID
Modernize typing for reviewboard.certs. This updates the `reviewboard.certs` codebase to use modern typing in preparation for upcoming work to integrate this into the rest of Review Board. It's a pretty routine change, and gets rid of a number of top-level imports.	b3d9f8b3fd79af372fb1b8af8e4a8cc9321a911a

Issues

Description	From	Last Updated
'django.utils.text.slugify' imported but unused Column: 1 Error code: F401	reviewbot	March 11, 2026, 11:50 p.m.
typo: str \| str -> str \| None	david	March 12, 2026, 7:35 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/certs/storage/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'django.utils.text.slugify' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Modernize typing for reviewboard.certs. This updates the `reviewboard.certs` codebase to use modern typing in preparation for upcoming work to integrate this into the rest of Review Board. It's a pretty routine change, and gets rid of a number of top-level imports.	f75177f1148ab30bec8402f640c8f115e18119a7
	Modernize typing for reviewboard.certs. This updates the `reviewboard.certs` codebase to use modern typing in preparation for upcoming work to integrate this into the rest of Review Board. It's a pretty routine change, and gets rid of a number of top-level imports.	c39a567e23b089f24d30eb8f42c5d9576d260ae6

Diff:

Revision 2 (+256 -486)

Show changes

	reviewboard/certs/cert.py
	reviewboard/certs/errors.py
	reviewboard/certs/manager.py
	reviewboard/certs/storage/base.py
	reviewboard/certs/storage/file_storage.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added some changes that were split into the wrong commit.

Commits:

	Summary	ID
	Modernize typing for reviewboard.certs. This updates the `reviewboard.certs` codebase to use modern typing in preparation for upcoming work to integrate this into the rest of Review Board. It's a pretty routine change, and gets rid of a number of top-level imports.	c39a567e23b089f24d30eb8f42c5d9576d260ae6
	Modernize typing for reviewboard.certs. This updates the `reviewboard.certs` codebase to use modern typing in preparation for upcoming work to integrate this into the rest of Review Board. It's a pretty routine change, and gets rid of a number of top-level imports.	b3d9f8b3fd79af372fb1b8af8e4a8cc9321a911a

Diff:

Revision 3 (+270 -506)

Show changes

	reviewboard/certs/cert.py
	reviewboard/certs/errors.py
	reviewboard/certs/manager.py
	reviewboard/certs/storage/base.py
	reviewboard/certs/storage/file_storage.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it! Fix it!

reviewboard/certs/cert.py (Diff revision 3)
An issue was opened. Show all issues
```
typo: str | str -> str | None
```

reviewboard/certs/cert.py (Diff revision 3)