Summary

Fix version and distro matching.

Review Request #14870 — Created March 4, 2026 and submitted March 6, 2026, 7:45 a.m.

Information

Owner

david

Repository

rbinstall

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change makes a couple fixes related to version matching:

The match_version() method would only match exactly the tuple,
where we mostly want to be matching on the major version. This has
been updated to match whatever length of tuple is passed in.
Several of the distro_info items listed the system as "linux", but
were supposed to be "Linux". This was causing a bunch of steps to be
improperly excluded.

The second of these changes required updates to several unit tests,
mostly adding in xmlsec libraries which are now getting (correctly)
installed.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix version and distro matching. This change makes a couple fixes related to version matching: - The `match_version()` method would only match exactly the tuple, where we mostly want to be matching on the major version. This has been updated to match whatever length of tuple is passed in. - Several of the distro_info items listed the system as "linux", but were supposed to be "Linux". This was causing a bunch of steps to be improperly excluded. The second of these changes required updates to several unit tests, mostly adding in xmlsec libraries which are now getting (correctly) installed. Testing Done: Ran unit tests.	rpsmqsopllxqswoqyxzswomnpomvptrv

Summary

Fix version and distro matching.

This change makes a couple fixes related to version matching: - The `match_version()` method would only match *exactly* the tuple, where we mostly want to be matching on the major version. This has been updated to match whatever length of tuple is passed in. - Several of the distro_info items listed the system as "linux", but were supposed to be "Linux". This was causing a bunch of steps to be improperly excluded. The second of these changes required updates to several unit tests, mostly adding in xmlsec libraries which are now getting (correctly) installed. Testing Done: Ran unit tests.

rpsmqsopllxqswoqyxzswomnpomvptrv

Issues

Description	From	Last Updated
line too long (97 > 79 characters) Column: 80 Error code: E501	reviewbot	March 4, 2026, 10:25 a.m.
line too long (97 > 79 characters) Column: 80 Error code: E501	reviewbot	March 4, 2026, 10:25 a.m.

flake8 failed.

JSHint passed.

flake8

rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (97 > 79 characters)

Column: 80
Error code: E501
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (97 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Fix version and distro matching. This change makes a couple fixes related to version matching: - The `match_version()` method would only match exactly the tuple, where we mostly want to be matching on the major version. This has been updated to match whatever length of tuple is passed in. - Several of the distro_info items listed the system as "linux", but were supposed to be "Linux". This was causing a bunch of steps to be improperly excluded. The second of these changes required updates to several unit tests, mostly adding in xmlsec libraries which are now getting (correctly) installed. Testing Done: Ran unit tests.	rpsmqsopllxqswoqyxzswomnpomvptrv
	Fix version and distro matching. This change makes a couple fixes related to version matching: - The `match_version()` method would only match exactly the tuple, where we mostly want to be matching on the major version. This has been updated to match whatever length of tuple is passed in. - Several of the distro_info items listed the system as "linux", but were supposed to be "Linux". This was causing a bunch of steps to be improperly excluded. The second of these changes required updates to several unit tests, mostly adding in xmlsec libraries which are now getting (correctly) installed. Testing Done: Ran unit tests.	rpsmqsopllxqswoqyxzswomnpomvptrv

Diff:

Revision 2 (+126 -16)

Show changes

	rbinstall/distro_info.py
	rbinstall/versioning.py
	rbinstall/tests/test_install_steps.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (89bab07)