Summary

Import integrations inside extension init.

Review Request #14861 — Created March 1, 2026 and submitted March 1, 2026, 10:42 p.m.

Information

Owner

david

Repository

rbintegrations

Branch

master

Bugs

Depends On

Reviewers

Groups

rbintegrations

People

Description

The djblets extension packaging build backend imports extension classes

in order to get metadata, which means that anything imported from the

extension needs to be present at build time, not just runtime.

rbintegrations' extension file was importing all of the individual

integration files, which in turn could import modules from third-party

dependencies.
This change moves those dependencies into the extension's initialize

method so it works with build isolation.

Testing Done

Did a test build.

Commits

Summary	ID
Import integrations inside extension init. The djblets extension packaging build backend imports extension classes in order to get metadata, which means that anything imported from the extension needs to be present at build time, not just runtime. rbintegrations' extension file was importing all of the individual integration files, which in turn could import modules from third-party dependencies. This change moves those dependencies into the extension's initialize method so it works with build isolation. Testing Done: Did a test build.	ntwponssmotvmrwulvtomlkxklzxxsll

Summary

Import integrations inside extension init.

The djblets extension packaging build backend imports extension classes in order to get metadata, which means that anything imported from the extension needs to be present at build time, not just runtime. rbintegrations' extension file was importing all of the individual integration files, which in turn could import modules from third-party dependencies. This change moves those dependencies into the extension's initialize method so it works with build isolation. Testing Done: Did a test build.

ntwponssmotvmrwulvtomlkxklzxxsll

Issues

Description	From	Last Updated
We should probably get rid of the integrations attribute now since nothing gets put in it, things get registered into …	maubin	March 1, 2026, 10:40 p.m.

flake8 passed.

JSHint passed.

rbintegrations/extension.py (Diff revision 1)

The issue has been resolved. Show all issues

We should probably get rid of the integrations attribute now since nothing gets put in it, things get registered into the IntegrationManager instead right? We should also check if we access RBIntegrationsExtension.integrations since that'll likely break now.

david March 1, 2026, 10:10 p.m.

Whoops, didn't realize I left the definition there. I've grepped for ".integrations" and there's no other use.

Commits:

	Summary	ID
	Import integrations inside extension init. The djblets extension packaging build backend imports extension classes in order to get metadata, which means that anything imported from the extension needs to be present at build time, not just runtime. rbintegrations' extension file was importing all of the individual integration files, which in turn could import modules from third-party dependencies. This change moves those dependencies into the extension's initialize method so it works with build isolation. Testing Done: Did a test build.	ntwponssmotvmrwulvtomlkxklzxxsll
	Import integrations inside extension init. The djblets extension packaging build backend imports extension classes in order to get metadata, which means that anything imported from the extension needs to be present at build time, not just runtime. rbintegrations' extension file was importing all of the individual integration files, which in turn could import modules from third-party dependencies. This change moves those dependencies into the extension's initialize method so it works with build isolation. Testing Done: Did a test build.	ntwponssmotvmrwulvtomlkxklzxxsll

Diff:

Revision 2 (+50 -60)

Show changes

rbintegrations/extension.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (1987e5c)