• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix outdated GitLabCI tests.
    
 
    

    



 
    
 
    

  Review Request #14848
  —
  Created Feb. 24, 2026 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  rbintegrations
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  rbintegrations
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Apparently as the GitLab CI change evolved, I neglected to update a few
    
test cases. This caused some breakages:
    

      

    • Many spies didn't have the same signature as the method they were
      
  replacing.
      • 

    • Several test data structures weren't complete, causing Pydantic
      
  validation errors.
      • 

    • The DONE_FAILURE state got changed in the implementation to use
      
ERROR because a "failed" result can result from ephemeral problems
      
  in GitLab CI, but the regular failed state doesn't allow a retry. The
      
  test never got updated to match.
      • 

    
 
    

    





  

    
 
 
    
  
    Ran unit tests.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Fix outdated GitLabCI tests.
      
    Apparently as the GitLab CI change evolved, I neglected to update a few
test cases. This caused some breakages:

- Many spies didn't have the same signature as the method they were
  replacing.
- Several test data structures weren't complete, causing Pydantic
  validation errors.
- The `DONE_FAILURE` state got changed in the implementation to use
  `ERROR` because a "failed" result can result from ephemeral problems
  in GitLab CI, but the regular failed state doesn't allow a retry. The
  test never got updated to match.

Testing Done:
Ran unit tests.
    
     
    

        		
    vxpuwromlrsqtsqnzrnrsmylspoklmvp

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



maubin




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
maubin


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to master (ec0b024)