Fish Trophy

david got a fish trophy!

Fish Trophy

Fix tests on Python 3.8 and 3.9.

Review Request #14841 — Created Feb. 19, 2026 and submitted

Information

Djblets
release-5.x

Reviewers

A couple instances of assertNoLogs were recently added to the codebase
which did not have an explicit logger argument. Python 3.10 has this
method in the standard library, but on 3.8 and 3.9 we get Django's
version, which differs very slightly from the stdlib one in that it does
not specify a None default for the logger argument. This caused tests
to break on those Python versions.

Ran unit tests.

Summary ID
Fix tests on Python 3.8 and 3.9.
A couple instances of `assertNoLogs` were recently added to the codebase which did not have an explicit `logger` argument. Python 3.10 has this method in the standard library, but on 3.8 and 3.9 we get Django's version, which differs very slightly from the stdlib one in that it does not specify a `None` default for the logger argument. This caused tests to break on those Python versions. Testing Done: Ran unit tests.
ozmxqtrxypkrswuwvsounlssupqlyuwo
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (b0ebeba)