Summary

Fix passing force_insert parameter to Model.save()

Review Request #14839 — Created Feb. 19, 2026 and submitted Feb. 26, 2026, 11:34 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The BaseComment tests had a test case that was passing the
force_insert parameter to the model's save() method as a positional
argument, with a value of None. Django has changed this to deprecated
positional arguments entirely for this method, and also now raise a
TypeError if it's not passed as a bool. This change updates our test
to remove that parameter.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix passing force_insert parameter to Model.save() The BaseComment tests had a test case that was passing the `force_insert` parameter to the model's `save()` method as a positional argument, with a value of `None`. Django has changed this to deprecated positional arguments entirely for this method, and also now raise a `TypeError` if it's not passed as a bool. This change updates our test to remove that parameter. Testing Done: Ran unit tests.	sszwsntxnssrlwnvnzxnuyqpmpxmnqvn

Summary

Fix passing force_insert parameter to Model.save()

The BaseComment tests had a test case that was passing the `force_insert` parameter to the model's `save()` method as a positional argument, with a value of `None`. Django has changed this to deprecated positional arguments entirely for this method, and also now raise a `TypeError` if it's not passed as a bool. This change updates our test to remove that parameter. Testing Done: Ran unit tests.

sszwsntxnssrlwnvnzxnuyqpmpxmnqvn

Issues

Description	From	Last Updated
You can get rid of this and its corresponding check in self.assertSpyCalledWith. I had only added it to make sure …	maubin	Feb. 25, 2026, 8:15 a.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/tests/test_base_comment.py (Diff revision 1)

The issue has been resolved. Show all issues

You can get rid of this and its corresponding check in self.assertSpyCalledWith. I had only added it to make sure that positional arguments get passed to the parent save method. We already test that custom keyword args get passed with update_fields. Plus the default value of force_insert is False anyways so this really isn't testing anything.

Description:

		The BaseComment tests had a test case that was passing the
		`force_insert` parameter to the model's `save()` method as a positional
		argument, with a value of `None`. Django has changed this to deprecated
		positional arguments entirely for this method, and also now raise a
		`TypeError` if it's not passed as a bool. This change updates our test
~		to pass it as a kwarg with a value of `False`.
	~	to remove that parameter.
	+
	+	Testing Done:
	+	Ran unit tests.

Commits:

	Summary	ID
	Fix passing force_insert parameter to Model.save() The BaseComment tests had a test case that was passing the `force_insert` parameter to the model's `save()` method as a positional argument, with a value of `None`. Django has changed this to deprecated positional arguments entirely for this method, and also now raise a `TypeError` if it's not passed as a bool. This change updates our test to pass it as a kwarg with a value of `False`. Testing Done: Ran unit tests.	sszwsntxnssrlwnvnzxnuyqpmpxmnqvn
	Fix passing force_insert parameter to Model.save() The BaseComment tests had a test case that was passing the `force_insert` parameter to the model's `save()` method as a positional argument, with a value of `None`. Django has changed this to deprecated positional arguments entirely for this method, and also now raise a `TypeError` if it's not passed as a bool. This change updates our test to remove that parameter. Testing Done: Ran unit tests.	sszwsntxnssrlwnvnzxnuyqpmpxmnqvn

Diff:

Revision 2 (-4)

Show changes

reviewboard/reviews/tests/test_base_comment.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:: The BaseComment tests had a test case that was passing the
force_insert parameter to the model's save() method as a positional
argument, with a value of None. Django has changed this to deprecated
positional arguments entirely for this method, and also now raise a
TypeError if it's not passed as a bool. This change updates our test
to remove that parameter.
-
-
Testing Done:
- Ran unit tests.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (fc666c8)