Summary

Expose FileDiff.patched_sha256 and FileDiff.orig_sha256 to the API.

Review Request #14790 — Created Jan. 28, 2026 and submitted Feb. 2, 2026, 6:14 p.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We have these SHA hashes for file diffs that are useful to checksum the
file diffs. They exist in the file diff's extra data and as attributes
on the object, but aren't officially listed in our API. It'd be useful
to expose them in the API so that callers can make use of them without
having to reach into the extra data and know the internal key naming of
the SHAs.

Testing Done


Ran unit tests.
Used in an upcoming RBTools change where I access the patched_sha256

  attribute via the API.

Commits

Summary	ID
Expose `FileDiff.patched_sha256` and `FileDiff.orig_sha256` to the API. We have these SHA hashes for file diffs that are useful to checksum the file diffs. They exist in the file diff's extra data and as attributes on the object, but aren't officially listed in our API. It'd be useful to expose them in the API so that callers can make use of them without having to reach into the extra data and know the internal key naming of the SHAs.	ad6ef22351060b200b19cafacb7b1e6f46750f1c

Summary

Expose `FileDiff.patched_sha256` and `FileDiff.orig_sha256` to the API.

We have these SHA hashes for file diffs that are useful to checksum the file diffs. They exist in the file diff's extra data and as attributes on the object, but aren't officially listed in our API. It'd be useful to expose them in the API so that callers can make use of them without having to reach into the extra data and know the internal key naming of the SHAs.

ad6ef22351060b200b19cafacb7b1e6f46750f1c

Issues

Description	From	Last Updated
Parameter name should be filediff.	david	Jan. 31, 2026, 10:15 p.m.
Because the underlying property can return None, this should probably be return filediff.orig_sha256 or ''	david	Jan. 31, 2026, 10:16 p.m.
Parameter name should be filediff.	david	Jan. 31, 2026, 10:16 p.m.
Same here about None.	david	Jan. 31, 2026, 10:16 p.m.
Can you use :py:attr: to reference the attribute here? It'll need to be the full class+attribute path.	chipx86	Feb. 1, 2026, 5:25 p.m.
Same here.	chipx86	Feb. 1, 2026, 5:25 p.m.

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/filediff.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Parameter name should be filediff.
```

reviewboard/webapi/resources/filediff.py (Diff revision 1)

The issue has been resolved. Show all issues

Because the underlying property can return None, this should probably be return filediff.orig_sha256 or ''

maubin Jan. 31, 2026, 10:44 p.m.

I'll change the return type hint instead, since None is a valid value.

reviewboard/webapi/resources/filediff.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Parameter name should be filediff.
```
reviewboard/webapi/resources/filediff.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here about None.
```

Commits:

	Summary	ID
	Expose `FileDiff.patched_sha256` and `FileDiff.orig_sha256` to the API. We have these SHA hashes for file diffs that are useful to checksum the file diffs. They exist in the file diff's extra data and as attributes on the object, but aren't officially listed in our API. It'd be useful to expose them in the API so that callers can make use of them without having to reach into the extra data and know the internal key naming of the SHAs.	98c2c7a050d9a82eaa136265a760d932735cc7c3
	Expose `FileDiff.patched_sha256` and `FileDiff.orig_sha256` to the API. We have these SHA hashes for file diffs that are useful to checksum the file diffs. They exist in the file diff's extra data and as attributes on the object, but aren't officially listed in our API. It'd be useful to expose them in the API so that callers can make use of them without having to reach into the extra data and know the internal key naming of the SHAs.	153e5f369f4aaa3d463160cd0b66da26fbb10565

Diff:

Revision 2 (+172)

Show changes

	reviewboard/webapi/resources/filediff.py
	reviewboard/webapi/tests/test_draft_filediff.py
	reviewboard/webapi/tests/test_filediff.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/webapi/resources/filediff.py (Diff revision 2)

The issue has been resolved. Show all issues

Can you use :py:attr: to reference the attribute here? It'll need to be the full class+attribute path.

reviewboard/webapi/resources/filediff.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same here.
```

Commits:

	Summary	ID
	Expose `FileDiff.patched_sha256` and `FileDiff.orig_sha256` to the API. We have these SHA hashes for file diffs that are useful to checksum the file diffs. They exist in the file diff's extra data and as attributes on the object, but aren't officially listed in our API. It'd be useful to expose them in the API so that callers can make use of them without having to reach into the extra data and know the internal key naming of the SHAs.	153e5f369f4aaa3d463160cd0b66da26fbb10565
	Expose `FileDiff.patched_sha256` and `FileDiff.orig_sha256` to the API. We have these SHA hashes for file diffs that are useful to checksum the file diffs. They exist in the file diff's extra data and as attributes on the object, but aren't officially listed in our API. It'd be useful to expose them in the API so that callers can make use of them without having to reach into the extra data and know the internal key naming of the SHAs.	ad6ef22351060b200b19cafacb7b1e6f46750f1c

Diff:

Revision 3 (+176)

Show changes

	reviewboard/webapi/resources/filediff.py
	reviewboard/webapi/tests/test_draft_filediff.py
	reviewboard/webapi/tests/test_filediff.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (b351d1c)