Summary

Allow resource item extra data tests to specify expected default extra data.

Review Request #14789 — Created Jan. 27, 2026 and submitted Feb. 2, 2026, 6:05 p.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We have a mixin that adds extra data-related tests for resource items.
It'll do full equality checks of the object's extra data against the
extra data that the test sets. However, it's possible that an object
can contain extra data entries that the mixin doesn't know about, but is
correct for it to exist in the extra data. An example of this is a file
attachment's SHA256 checksum value, which gets put into the extra data
upon file attachment creation and whenever the item resource is
serialized.

This change allows test cases to set additional expected extra data for
the object, so that tests can account for this when checking that the
object's extra data is correct.

Testing Done


Ran unit tests.
Used in the upcoming file attachment SHA256 change where this

  fixed some unit tests.

Commits

Summary	ID
Allow resource item extra data tests to specify expected default extra data. We have a mixin that adds extra data-related tests for resource items. It'll do full equality checks of the object's extra data against the extra data that the test sets. However, it's possible that an object can contain extra data entries that the mixin doesn't know about, but is correct for it to exist in the extra data. An example of this is a file attachment's SHA256 checksum value, which gets put into the extra data upon file attachment creation and whenever the item resource is serialized. This change allows test cases to set additional expected extra data for the object, so that tests can account for this when checking that the object's extra data is correct.	518522bad20e2bc1ddaeb926503f9c5015da454d

Summary

Allow resource item extra data tests to specify expected default extra data.

We have a mixin that adds extra data-related tests for resource items. It'll do full equality checks of the object's extra data against the extra data that the test sets. However, it's possible that an object can contain extra data entries that the mixin doesn't know about, but is correct for it to exist in the extra data. An example of this is a file attachment's SHA256 checksum value, which gets put into the extra data upon file attachment creation and whenever the item resource is serialized. This change allows test cases to set additional expected extra data for the object, so that tests can account for this when checking that the object's extra data is correct.

518522bad20e2bc1ddaeb926503f9c5015da454d

Issues

Description	From	Last Updated
Blank line between these.	david	Jan. 31, 2026, 8:51 p.m.
Do we want to check value equality as well as the presence of the key?	david	Jan. 31, 2026, 9:14 p.m.
Same here.	david	Jan. 31, 2026, 9:14 p.m.
And here. If it turns out we do, we might want to write a helper method to check these since …	david	Jan. 31, 2026, 9:14 p.m.

flake8 passed.

JSHint passed.

reviewboard/webapi/tests/mixins_extra_data.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/webapi/tests/mixins_extra_data.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Do we want to check value equality as well as the presence of the key?
```
reviewboard/webapi/tests/mixins_extra_data.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```

reviewboard/webapi/tests/mixins_extra_data.py (Diff revision 1)

The issue has been resolved. Show all issues

And here.

If it turns out we do, we might want to write a helper method to check these since we're doing it three times.

Commits:

	Summary	ID
	Allow resource item extra data tests to specify expected default extra data. We have a mixin that adds extra data-related tests for resource items. It'll do full equality checks of the object's extra data against the extra data that the test sets. However, it's possible that an object can contain extra data entries that the mixin doesn't know about, but is correct for it to exist in the extra data. An example of this is a file attachment's SHA256 checksum value, which gets put into the extra data upon file attachment creation and whenever the item resource is serialized. This change allows test cases to set additional expected extra data for the object, so that tests can account for this when checking that the object's extra data is correct.	eb44898d567e8a888a33865812a24a9c1bcb4a50
	Allow resource item extra data tests to specify expected default extra data. We have a mixin that adds extra data-related tests for resource items. It'll do full equality checks of the object's extra data against the extra data that the test sets. However, it's possible that an object can contain extra data entries that the mixin doesn't know about, but is correct for it to exist in the extra data. An example of this is a file attachment's SHA256 checksum value, which gets put into the extra data upon file attachment creation and whenever the item resource is serialized. This change allows test cases to set additional expected extra data for the object, so that tests can account for this when checking that the object's extra data is correct.	518522bad20e2bc1ddaeb926503f9c5015da454d

Diff:

Revision 2 (+142)

Show changes

reviewboard/webapi/tests/mixins_extra_data.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (68410b7)