Summary

Fix up logging issues.

Review Request #14779 — Created Jan. 12, 2026 and submitted Jan. 14, 2026, 9:40 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change fixes up a variety of issues with our logging code:

Many places were logging to the root logger instead of named loggers.
Commands had a mix of root loggers and named loggers but they should
all have been using self.log instead.
A few places were formatting strings before the logging call, rather
than passing them in as arguments.

Testing Done


Ran unit tests.
Verified that code updated to use self.log showed output

  appropriately.

Commits

Summary	ID
Fix up logging issues. This change fixes up a variety of issues with our logging code: - Many places were logging to the root logger instead of named loggers. - Commands had a mix of root loggers and named loggers but they should all have been using `self.log` instead. - A few places were formatting strings before the logging call, rather than passing them in as arguments. Testing Done: - Ran unit tests. - Verified that code updated to use `self.log` showed output appropriately.	qkxzsntyzkqyozwxqnplwmtsktoryoqz

Summary

Fix up logging issues.

This change fixes up a variety of issues with our logging code: - Many places were logging to the root logger instead of named loggers. - Commands had a mix of root loggers and named loggers but they should all have been using `self.log` instead. - A few places were formatting strings before the logging call, rather than passing them in as arguments. Testing Done: - Ran unit tests. - Verified that code updated to use `self.log` showed output appropriately.

qkxzsntyzkqyozwxqnplwmtsktoryoqz

Issues

Description	From	Last Updated
Should we pull self.log out into a variable then use that here and below.	maubin	Jan. 14, 2026, 8:39 a.m.
Same comment here about pulling self.log out into a variable.	maubin	Jan. 14, 2026, 8:40 a.m.

flake8 passed.

JSHint passed.

rbtools/commands/install.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should we pull self.log out into a variable then use that here and below.
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same comment here about pulling self.log out into a variable.
```

Commits:

	Summary	ID
	Fix up logging issues. This change fixes up a variety of issues with our logging code: - Many places were logging to the root logger instead of named loggers. - Commands had a mix of root loggers and named loggers but they should all have been using `self.log` instead. - A few places were formatting strings before the logging call, rather than passing them in as arguments. Testing Done: - Ran unit tests. - Verified that code updated to use `self.log` showed output appropriately.	qkxzsntyzkqyozwxqnplwmtsktoryoqz
	Fix up logging issues. This change fixes up a variety of issues with our logging code: - Many places were logging to the root logger instead of named loggers. - Commands had a mix of root loggers and named loggers but they should all have been using `self.log` instead. - A few places were formatting strings before the logging call, rather than passing them in as arguments. Testing Done: - Ran unit tests. - Verified that code updated to use `self.log` showed output appropriately.	qkxzsntyzkqyozwxqnplwmtsktoryoqz

Diff:

Revision 2 (+680 -604)

Show changes

	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/clients/__init__.py
	rbtools/clients/bazaar.py
	rbtools/clients/cvs.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	23 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (2b7dd84)

rbtools/commands/install.py (Diff revision 1)

rbtools/commands/post.py (Diff revision 1)