Summary

Update typing: Dict[...]

Review Request #14773 — Created Jan. 12, 2026 and submitted Jan. 12, 2026, 9:56 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change updates the type hints in the rbtools codebase to replace

Dict[...] with either dict[...] or Mapping[...] as appropriate (or

in a couple cases, RBToolsConfig).

Testing Done

Ran unit tests.

Commits

Summary	ID
Update typing: Dict[...] This change updates the type hints in the rbtools codebase to replace `Dict[...]` with either `dict[...]` or `Mapping[...]` as appropriate (or in a couple cases, `RBToolsConfig`). Testing Done: Ran unit tests.	lxqklrlrulynqkzllzlmskvlrnsourus

Issues

Description	From	Last Updated
'collections.abc.Mapping' imported but unused Column: 1 Error code: F401	reviewbot	Jan. 12, 2026, 9:52 a.m.
Can we use \| None here instead of Optional?	maubin	Jan. 12, 2026, 1:10 p.m.
Can we use \| None here instead of Optional?	maubin	Jan. 12, 2026, 1:10 p.m.
Aside: isn't it bad to use empty dicts as default values because they can be mutated between calls? Maybe not …	maubin	Jan. 12, 2026, 1:11 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/config/config.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'collections.abc.Mapping' imported but unused

Column: 1
Error code: F401
```

Commits:

	Summary	ID
	Update typing: Dict[...] This change updates the type hints in the rbtools codebase to replace `Dict[...]` with either `dict[...]` or `Mapping[...]` as appropriate (or in a couple cases, `RBToolsConfig`). Testing Done: Ran unit tests.	lxqklrlrulynqkzllzlmskvlrnsourus
	Update typing: Dict[...] This change updates the type hints in the rbtools codebase to replace `Dict[...]` with either `dict[...]` or `Mapping[...]` as appropriate (or in a couple cases, `RBToolsConfig`). Testing Done: Ran unit tests.	lxqklrlrulynqkzllzlmskvlrnsourus

Diff:

Revision 2 (+178 -144)

Show changes

	rbtools/clients/clearcase.py
	rbtools/clients/svn.py
	rbtools/clients/tfs.py
	rbtools/clients/base/scmclient.py
	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_sos.py
	rbtools/clients/tests/test_tfs.py
	rbtools/commands/base/output.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/base/scmclient.py (Diff revision 2)

The issue has been dropped. Show all issues

Can we use | None here instead of Optional?

david Jan. 12, 2026, 1:11 p.m.

That will come in a later change. I want to keep these tightly focused.

rbtools/clients/svn.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Can we use | None here instead of Optional?
```

rbtools/clients/tests/__init__.py (Diff revision 2)

The issue has been dropped. Show all issues

Aside: isn't it bad to use empty dicts as default values because they can be mutated between calls? Maybe not a problem since this is only for unit tests.

david Jan. 12, 2026, 1:11 p.m.

Yes, it is. Again, not something I'd want to include in this particular change.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (3d5de6d)