Summary

Correct some of the types in our API resources.

Review Request #14769 — Created Jan. 8, 2026 and submitted Jan. 11, 2026, 6:41 p.m.

Information

Owner

maubin

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This corrects the following types:
- ListResource iterators are typed as yielding TItemResource instead
of Any.
- FileDiff.dest_file and FileDiff.dest_detail are now non-None, which
matches Review Board's API.

We also get rid of the __nonzero__ method on the ListResource because its
only needed for Python 2, in Python 3 it gets replaced with __bool__.

Testing Done

Used in an upcoming change.

Commits

Summary	ID
Correct some of the types in our API resources. This corrects the following types: - `ListResource` iterators are typed as yielding `TItemResource` instead of `Any`. - `FileDiff.dest_file` and `FileDiff.dest_detail` are now non-None, which matches Review Board's API. We also get rid of the `__nonzero__` method on the `ListResource` because its only needed for Python 2, in Python 3 it gets replaced with `__bool__`.	c3793863cc0bc52a1b5377b3d45e28d5e320a7cd

Summary

Correct some of the types in our API resources.

This corrects the following types: - `ListResource` iterators are typed as yielding `TItemResource` instead of `Any`. - `FileDiff.dest_file` and `FileDiff.dest_detail` are now non-None, which matches Review Board's API. We also get rid of the `__nonzero__` method on the `ListResource` because its only needed for Python 2, in Python 3 it gets replaced with `__bool__`.

c3793863cc0bc52a1b5377b3d45e28d5e320a7cd

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (fbbdd6c)