Summary

Don't emit migrations signals if there's no migration plan.

Review Request #14746 — Created Dec. 23, 2025 and submitted Feb. 19, 2026, 8:25 a.m.

Information

Owner

david

Repository

Django Evolution

Branch

master

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

An updated signal handler for the pre/post migrations signals inside
Django was assuming that the plan argument was not None, and was
crashing when we would emit those signals.

This change moves those signal emissions inside the nearby conditionals
so we only emit them if we're actually doing anything with migrations.

This also sets a default value for full_migration_plan so that static
checkers don't warn about it possibly being unbound.

Testing Done

Ran unit tests without causing a crash deep inside Django.

Commits

Summary	ID
Don't emit migrations signals if there's no migration plan. An updated signal handler for the pre/post migrations signals inside Django was assuming that the `plan` argument was not None, and was crashing when we would emit those signals. This change moves those signal emissions inside the nearby conditionals so we only emit them if we're actually doing anything with migrations. This also sets a default value for `full_migration_plan` so that static checkers don't warn about it possibly being unbound. Testing Done: Ran unit tests without causing a crash deep inside Django.	muvptuyptkulyuuokussrrwumxpkwyrl

Summary

Don't emit migrations signals if there's no migration plan.

An updated signal handler for the pre/post migrations signals inside Django was assuming that the `plan` argument was not None, and was crashing when we would emit those signals. This change moves those signal emissions inside the nearby conditionals so we only emit them if we're actually doing anything with migrations. This also sets a default value for `full_migration_plan` so that static checkers don't warn about it possibly being unbound. Testing Done: Ran unit tests without causing a crash deep inside Django.

muvptuyptkulyuuokussrrwumxpkwyrl

Issues

Description	From	Last Updated
I think this is correct now that we're dropping syncdb-supporting Django versions, but it wouldn't have been for those. It …	chipx86	Dec. 29, 2025, 10:51 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

I think this is correct now that we're dropping syncdb-supporting Django versions, but it wouldn't have been for those. It might be worth adding a note in the comments calling these stating that these used to be called unconditionally but are now only called if we now we're migrating and therefore have a plan. I think otherwise the rationale for this change can get lost over time as code is moved around, and it might be notable.

Commits:

	Summary	ID
	Don't emit migrations signals if there's no migration plan. An updated signal handler for the pre/post migrations signals inside Django was assuming that the `plan` argument was not None, and was crashing when we would emit those signals. This change moves those signal emissions inside the nearby conditionals so we only emit them if we're actually doing anything with migrations. This also sets a default value for `full_migration_plan` so that static checkers don't warn about it possibly being unbound. Testing Done: Ran unit tests without causing a crash deep inside Django.	muvptuyptkulyuuokussrrwumxpkwyrl
	Don't emit migrations signals if there's no migration plan. An updated signal handler for the pre/post migrations signals inside Django was assuming that the `plan` argument was not None, and was crashing when we would emit those signals. This change moves those signal emissions inside the nearby conditionals so we only emit them if we're actually doing anything with migrations. This also sets a default value for `full_migration_plan` so that static checkers don't warn about it possibly being unbound. Testing Done: Ran unit tests without causing a crash deep inside Django.	muvptuyptkulyuuokussrrwumxpkwyrl

Diff:

Revision 2 (+54 -32)

Show changes

django_evolution/evolve/evolve_app_task.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (80a7490)