Summary

Handle CheckConstraint.check -> condition.

Review Request #14743 — Created Dec. 22, 2025 and updated Feb. 16, 2026, 11:55 a.m.

Information

Owner

david

Repository

Django Evolution

Branch

master

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

Django 5.1 renamed the check argument/field inside CheckConstraint
to condition, and 6.0 removed the check argument entirely. This
change adds a support flag and conditions to handle these updates. The
ChangeMeta and ConstraintSignature objects have been updated to
normalize old evolutions and signatures appropriately.

Testing Done

Ran unit tests.

Commits

Summary	ID
Handle CheckConstraint.check -> condition. Django 5.1 renamed the `check` argument/field inside `CheckConstraint` to `condition`, and 6.0 removed the `check` argument entirely. This change adds a support flag and conditions to handle these updates. The `ChangeMeta` and `ConstraintSignature` objects have been updated to normalize old evolutions and signatures appropriately. Testing Done: Ran unit tests.	nnsntwsplxpzozktqypmupvyxlqxrqyn

Summary

Handle CheckConstraint.check -> condition.

Django 5.1 renamed the `check` argument/field inside `CheckConstraint` to `condition`, and 6.0 removed the `check` argument entirely. This change adds a support flag and conditions to handle these updates. The `ChangeMeta` and `ConstraintSignature` objects have been updated to normalize old evolutions and signatures appropriately. Testing Done: Ran unit tests.

nnsntwsplxpzozktqypmupvyxlqxrqyn

Issues

Description	From	Last Updated
) should be on the next line, with a comma on this line.	chipx86	Dec. 29, 2025, 8:52 a.m.
This can be one statement.	chipx86	Dec. 29, 2025, 9:36 a.m.
This can also be one statement.	chipx86	Dec. 29, 2025, 9:36 a.m.
These, too.	chipx86	Dec. 29, 2025, 9:37 a.m.
) should be on the next line, with a comma on this line.	chipx86	Dec. 29, 2025, 8:53 a.m.
This can be one statement.	chipx86	Dec. 29, 2025, 9:36 a.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Dec. 30, 2025, 11:55 a.m.
As we type things, we'll need to make a decision on whether the classes own the arguments going in, or …	chipx86	Feb. 16, 2026, 11:54 a.m.
This should probably use is.	chipx86	Feb. 16, 2026, 11:32 a.m.
Instead of the del, you can use .pop().	chipx86	Feb. 16, 2026, 11:33 a.m.
This should probably use is for comparison.	chipx86	Feb. 16, 2026, 11:33 a.m.
This is missing a Version Added.	chipx86	Feb. 16, 2026, 11:33 a.m.
We do this a lot. We may want to just have a global.	chipx86	Feb. 16, 2026, 11:54 a.m.

flake8 passed.

JSHint passed.

We'll need to handle evolutions using one form or the other, ensuring the attribute is renamed for the target version of Django.

django_evolution/tests/test_change_meta.py (Diff revision 1)
The issue has been resolved. Show all issues
```
) should be on the next line, with a comma on this line.
```
django_evolution/tests/test_change_meta.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be one statement.
```
django_evolution/tests/test_change_meta.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can also be one statement.
```

django_evolution/tests/test_change_meta.py (Diff revision 1)

The issue has been resolved. Show all issues

These, too.

django_evolution/tests/test_signature.py (Diff revision 1)
The issue has been resolved. Show all issues
```
) should be on the next line, with a comma on this line.
```
django_evolution/tests/test_signature.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be one statement.
```

Summary:

Handle CheckConstraint.check -> condition

Handle CheckConstraint.check -> condition.

Description:

		Django 5.1 renamed the `check` argument/field inside `CheckConstraint`
		to `condition`, and 6.0 removed the `check` argument entirely. This
~		change adds a support flag and conditions to handle these updates.
	~	change adds a support flag and conditions to handle these updates. The
	+	`ChangeMeta` and `ConstraintSignature` objects have been updated to
	+	normalize old evolutions and signatures appropriately.

Commits:

	Summary	ID
	Handle CheckConstraint.check -> condition Django 5.1 renamed the `check` argument/field inside `CheckConstraint` to `condition`, and 6.0 removed the `check` argument entirely. This change adds a support flag and conditions to handle these updates. Testing Done: Ran unit tests.	nnsntwsplxpzozktqypmupvyxlqxrqyn
	Handle CheckConstraint.check -> condition. Django 5.1 renamed the `check` argument/field inside `CheckConstraint` to `condition`, and 6.0 removed the `check` argument entirely. This change adds a support flag and conditions to handle these updates. The `ChangeMeta` and `ConstraintSignature` objects have been updated to normalize old evolutions and signatures appropriately. Testing Done: Ran unit tests.	nnsntwsplxpzozktqypmupvyxlqxrqyn

Diff:

Revision 2 (+648 -174)

Show changes

	django_evolution/signature.py
	django_evolution/support.py
	django_evolution/mutations/change_meta.py
	django_evolution/tests/test_change_meta.py
	django_evolution/tests/test_signature.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

django_evolution/tests/test_change_meta.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Handle CheckConstraint.check -> condition. Django 5.1 renamed the `check` argument/field inside `CheckConstraint` to `condition`, and 6.0 removed the `check` argument entirely. This change adds a support flag and conditions to handle these updates. The `ChangeMeta` and `ConstraintSignature` objects have been updated to normalize old evolutions and signatures appropriately. Testing Done: Ran unit tests.	nnsntwsplxpzozktqypmupvyxlqxrqyn
	Handle CheckConstraint.check -> condition. Django 5.1 renamed the `check` argument/field inside `CheckConstraint` to `condition`, and 6.0 removed the `check` argument entirely. This change adds a support flag and conditions to handle these updates. The `ChangeMeta` and `ConstraintSignature` objects have been updated to normalize old evolutions and signatures appropriately. Testing Done: Ran unit tests.	nnsntwsplxpzozktqypmupvyxlqxrqyn

Diff:

Revision 3 (+654 -174)

Show changes

	django_evolution/signature.py
	django_evolution/support.py
	django_evolution/mutations/change_meta.py
	django_evolution/tests/test_change_meta.py
	django_evolution/tests/test_signature.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

django_evolution/mutations/change_meta.py (Diff revision 3)

The issue has been resolved. Show all issues

As we type things, we'll need to make a decision on whether the classes own the arguments going in, or if those values should be untouched.

My feeling is they should be untouched, so the definitions don't have any side-effects.

In that case, we'd need to make sure we copy new_value before modifying it.

If we don't go that way, we need to make sure we document that the argument may be modified by this class.

django_evolution/mutations/change_meta.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This should probably use is.
```
django_evolution/mutations/change_meta.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Instead of the del, you can use .pop().
```
django_evolution/signature.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This should probably use is for comparison.
```
django_evolution/support.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This is missing a Version Added.
```
django_evolution/tests/test_change_meta.py (Diff revision 3)
The issue has been resolved. Show all issues
```
We do this a lot. We may want to just have a global.
```

Commits:

	Summary	ID
	Handle CheckConstraint.check -> condition. Django 5.1 renamed the `check` argument/field inside `CheckConstraint` to `condition`, and 6.0 removed the `check` argument entirely. This change adds a support flag and conditions to handle these updates. The `ChangeMeta` and `ConstraintSignature` objects have been updated to normalize old evolutions and signatures appropriately. Testing Done: Ran unit tests.	nnsntwsplxpzozktqypmupvyxlqxrqyn
	Handle CheckConstraint.check -> condition. Django 5.1 renamed the `check` argument/field inside `CheckConstraint` to `condition`, and 6.0 removed the `check` argument entirely. This change adds a support flag and conditions to handle these updates. The `ChangeMeta` and `ConstraintSignature` objects have been updated to normalize old evolutions and signatures appropriately. Testing Done: Ran unit tests.	nnsntwsplxpzozktqypmupvyxlqxrqyn

Diff:

Revision 4 (+646 -176)

Show changes

	django_evolution/signature.py
	django_evolution/support.py
	django_evolution/mutations/change_meta.py
	django_evolution/tests/test_change_meta.py
	django_evolution/tests/test_signature.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.