Remove the unnecessary -S option for modern clang.

Review Request #14733 — Created Dec. 11, 2025 and updated — Latest diff uploaded

Information

ReviewBot
release-5.x

Reviewers

A long time ago, the -S option that we passed to clang --analyze ...
used to matter to tell clang to compile to assembly and then stop. But
modern versions of clang now ignore any code generation related flags
when --analyze is passed, so this -S option isn't needed anymore.

Clang 15 and newer is more noisy about unused arguments during
compilation, so it was complaining about the -S. This change removes
the option from our command.

  • Ran integration unit tests with clang 20 and saw that the unused
    argument warnings that were causing a couple tests to fail went away.

Commits

Files