• 
      

    Add a Tool setting for only notifying the review request owner upon reviews.

    Review Request #14719 — Created Dec. 1, 2025 and submitted

    Information

    ReviewBot
    release-4.x

    Reviewers

    We've had requests for allowing users to be opted out of Review Bot
    e-mail notifications, so that only the review request owner gets
    notifications from Review Bot reviews.

    This change adds a tool setting to allow for this. When enabled, e-mail
    notifications of Review Bot reviews will only be sent to the owner of
    the review request. This makes use of our existing to_owner_only flag
    for reviews, plumbing it through to Review Bot.

    • Used the setting on a tool, saw that the email notification was only
      sent to the review request owner when the setting was enabled. And
      that it went to the reviewers as well when the setting was disabled.
    • Ran unit tests.
    Summary ID
    Add a Tool setting for only notifying the review request owner upon reviews.
    We've had requests for allowing users to be opted out of Review Bot e-mail notifications, so that only the review request owner gets notifications from Review Bot reviews. This change adds a tool setting to allow for this. When enabled, e-mail notifications of Review Bot reviews will only be sent to the owner of the review request. This makes use of our existing `to_owner_only` flag for reviews, plumbing it through to Review Bot.
    b7ac921985fa066662ae58fdf7992246b08c3ffe
    Description From Last Updated

    The summary needs to be one line. I think if you replace "address" with "send", it fits.

    chipx86chipx86

    Based on discussions in Slack, it sounds like we're going with 5.0. This and other versions can be updated.

    chipx86chipx86

    Just to help give this more breathing room, you can do: help_text=_( '...' '...' )

    chipx86chipx86

    We have this issue in a bunch of places, but in the case of a version mismatch between the extension …

    daviddavid

    Other fields here don't have periods in the label.

    daviddavid
    chipx86
    1. 
        
    2. extension/reviewbotext/forms.py (Diff revision 1)
       
       
       
      Show all issues

      The summary needs to be one line. I think if you replace "address" with "send", it fits.

    3. extension/reviewbotext/forms.py (Diff revision 1)
       
       
       
      Show all issues

      Based on discussions in Slack, it sounds like we're going with 5.0. This and other versions can be updated.

    4. extension/reviewbotext/forms.py (Diff revision 1)
       
       
       
       
      Show all issues

      Just to help give this more breathing room, you can do:

      help_text=_(
          '...'
          '...'
      )
      
    5. 
        
    maubin
    david
    1. 
        
    2. bot/reviewbot/processing/review.py (Diff revision 2)
       
       
      Show all issues

      We have this issue in a bunch of places, but in the case of a version mismatch between the extension and the worker, this could be a KeyError. We probably should use self.gettings.get('notify_owner_only', False)

    3. 
        
    maubin
    chipx86
    1. Ship It!
    2. 
        
    david
    1. 
        
    2. extension/reviewbotext/forms.py (Diff revision 3)
       
       
      Show all issues

      Other fields here don't have periods in the label.

    3. 
        
    maubin
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.x (f151328)