Summary

Add Mercurial binary file patching.

Review Request #14718 — Created Nov. 29, 2025 and submitted Jan. 9, 2026, 11:20 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change adds support to the MercurialPatcher for applying binary

files as part of changes. This is relatively straightforward for

Mercurial, where we just have to let hg know about adds, moves, and

deletes.

Testing Done


Ran unit tests.
Used rbt patch with a bunch of changes that did various file

  operations on binary files.

Commits

Summary	ID
Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw

Issues

Description	From	Last Updated
line too long (83 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 12:32 p.m.
Can you make this one line.	maubin	Jan. 8, 2026, 8:38 a.m.
Let's list OSError here too since we call super().handle_add_file	maubin	Jan. 8, 2026, 8:38 a.m.
We can remove this one I think since we don't call super() here.	maubin	Jan. 8, 2026, 8:39 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_mercurial.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (83 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw
	Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw

Diff:

Revision 2 (+2350 -90)

Show changes

	rbtools/clients/mercurial.py
	rbtools/clients/tests/test_mercurial.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Use new make_binary_file_patch helper.

Commits:

	Summary	ID
	Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw
	Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw

Diff:

Revision 3 (+2168 -90)

Show changes

	rbtools/clients/mercurial.py
	rbtools/clients/tests/test_mercurial.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw
	Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw

Diff:

Revision 4 (+2186 -90)

Show changes

	rbtools/clients/mercurial.py
	rbtools/clients/tests/test_mercurial.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/mercurial.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Can you make this one line.
```
rbtools/clients/mercurial.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Let's list OSError here too since we call super().handle_add_file
```
rbtools/clients/mercurial.py (Diff revision 4)
The issue has been dropped. Show all issues
```
We can remove this one I think since we don't call super() here.
```
1. david Jan. 8, 2026, 8:48 a.m.
  The makedirs() call can fail.

Commits:

	Summary	ID
	Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw
	Add Mercurial binary file patching. This change adds support to the `MercurialPatcher` for applying binary files as part of changes. This is relatively straightforward for Mercurial, where we just have to let hg know about adds, moves, and deletes. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	omnrmqxwlqtokvlznzlnpxymzulxuvpw

Diff:

Revision 5 (+2190 -90)

Show changes

	rbtools/clients/mercurial.py
	rbtools/clients/tests/test_mercurial.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (430e08d)