Summary

Add SVN binary file patching.

Review Request #14717 — Created Nov. 29, 2025 and submitted Jan. 9, 2026, 11:20 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change adds support to the SVNPatcher for applying binary files
as part of changes. Things have been reorganized a little bit in order
to make it easier to deal with both empty files and binary files, which
appear similarly in the diff.

Additionally, several of our tests had index lines that did not start
with a /, which was inconsistent with real-world data. I've fixed
these up to match.

Testing Done


Ran unit tests.
Used rbt patch with a bunch of changes that did various file

  operations on binary files.

Commits

Summary	ID
Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy

Summary

Add SVN binary file patching.

This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.

xlmyyqprwnolxknqmzqskqkvpurszzwy

Issues

Description	From	Last Updated
continuation line over-indented for hanging indent Column: 29 Error code: E126	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (96 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (92 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (92 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (92 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (89 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:53 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Nov. 29, 2025, 11:55 a.m.
Should we just do an else here since we have if empty above.	maubin	Jan. 8, 2026, 8:23 a.m.
Can you add a Version Added to the docstring for this.	maubin	Jan. 8, 2026, 8:23 a.m.
We could pull this out into a patch_binary_files variable and use it below.	maubin	Jan. 8, 2026, 8:23 a.m.
Can you add types to these.	maubin	Jan. 8, 2026, 8:24 a.m.
Can you add a type for this.	maubin	Jan. 8, 2026, 8:26 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/svn.py (Diff revision 1)

The issue has been dropped. Show all issues

continuation line over-indented for hanging indent

Column: 29
Error code: E126

rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (96 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (92 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (92 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (92 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (89 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
rbtools/clients/tests/test_svn.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy

Diff:

Revision 2 (+2134 -454)

Show changes

	rbtools/clients/svn.py
	rbtools/clients/tests/test_svn.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_svn.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy

Diff:

Revision 3 (+2136 -454)

Show changes

	rbtools/clients/svn.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:: This change adds support to the SVNPatcher for applying binary files
as part of changes. Things have been reorganized a little bit in order
to make it easier to deal with both empty files and binary files, which
appear similarly in the diff.

Additionally, several of our tests had index lines that did not start
with a /, which was inconsistent with real-world data. I've fixed
these up to match.
-
-
Testing Done:
- - Ran unit tests.
- - Used rbt patch with a bunch of changes that did various file
- operations on binary files.
Testing Done:: +
Ran unit tests.
+
Used rbt patch with a bunch of changes that did various file
operations on binary files.

Change Summary:

Use new make_binary_file_patch helper.

Commits:

	Summary	ID
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy

Diff:

Revision 4 (+1996 -454)

Show changes

	rbtools/clients/svn.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy

Diff:

Revision 5 (+2014 -454)

Show changes

	rbtools/clients/svn.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/svn.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Should we just do an else here since we have if empty above.
```
rbtools/clients/svn.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Can you add a Version Added to the docstring for this.
```

rbtools/clients/svn.py (Diff revision 5)

The issue has been resolved. Show all issues

We could pull this out into a patch_binary_files variable and use it below.

rbtools/clients/svn.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Can you add types to these.
```
rbtools/clients/svn.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Can you add a type for this.
```

Commits:

	Summary	ID
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy
	Add SVN binary file patching. This change adds support to the `SVNPatcher` for applying binary files as part of changes. Things have been reorganized a little bit in order to make it easier to deal with both empty files and binary files, which appear similarly in the diff. Additionally, several of our tests had index lines that did not start with a `/`, which was inconsistent with real-world data. I've fixed these up to match. Testing Done: - Ran unit tests. - Used `rbt patch` with a bunch of changes that did various file operations on binary files.	xlmyyqprwnolxknqmzqskqkvpurszzwy

Diff:

Revision 6 (+2028 -460)

Show changes

	rbtools/clients/svn.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (77e0eb6)

		This change adds support to the `SVNPatcher` for applying binary files
		as part of changes. Things have been reorganized a little bit in order
		to make it easier to deal with both empty files and binary files, which
		appear similarly in the diff.

		Additionally, several of our tests had index lines that did not start
		with a `/`, which was inconsistent with real-world data. I've fixed
		these up to match.
-
-		Testing Done:
-		- Ran unit tests.
-		- Used `rbt patch` with a bunch of changes that did various file
-		operations on binary files.

	+	Ran unit tests.
	+	Used `rbt patch` with a bunch of changes that did various file operations on binary files.